Fix some VS 2015 warnings

Fix some VS 2015 warnings

Fix some warnings when compiling crashpad with VC++ 2015 Update 1.

Warning 4302 occurs if you convert from a pointer to a <sizeof(void*)
integer in one cast, because this often indicates an accidental pointer
truncation which can be a bug in 64-bit builds.

Warning 4577 warns that noexcept will not be enforced, but we don't want
it to be enforced anyway, so I disabled it. The full warning is:

warning C4577: 'noexcept' used with no exception handling mode specified
termination on exception is not guaranteed. Specify /EHsc

BUG=440500
R=mark@chromium.org

Committed: https://chromium.googlesource.com/crashpad/crashpad/+/b0394744cc41a846eb9a79ccc73cd2992790ed42

[brucedawson, 2015-12-14 22:46:01]

Description was changed from

==========
Fix some VS 2015 warnings

This fixes some warnings when compiling crashpad with VC++ 2015 Update
1.

Warning 4302 occurs if you convert from a pointer to a <sizeof(void*)
integer in one cast, because this often indicates an accidental pointer
truncation which can be a bug in 64-bit builds.

Warning 4577 warns that noexcept will not be enforced, but we don't want
it to be enforced anyway, so I disabled it. The full warning is:

warning C4577: 'noexcept' used with no exception handling mode specified
termination on exception is not guaranteed. Specify /EHsc

BUG=440500
==========

to

==========
Fix some VS 2015 warnings

Fix some warnings when compiling crashpad with VC++ 2015 Update 1.

Warning 4302 occurs if you convert from a pointer to a <sizeof(void*)
integer in one cast, because this often indicates an accidental pointer
truncation which can be a bug in 64-bit builds.

Warning 4577 warns that noexcept will not be enforced, but we don't want
it to be enforced anyway, so I disabled it. The full warning is:

warning C4577: 'noexcept' used with no exception handling mode specified
termination on exception is not guaranteed. Specify /EHsc

BUG=440500
==========

[brucedawson, 2015-12-14 22:46:01]

brucedawson@chromium.org changed reviewers:
+ mark@chromium.org, scottmg@chromium.org

[brucedawson, 2015-12-14 22:46:49]

If one of you could take a look and approve that would be appreciated.

There should be no behavioral change, and C4577 does not seem like a warning
that we ever want to see. It would be nice if it was documented...

[Mark Mentovai, 2015-12-14 23:51:30]

https://codereview.chromium.org/1527803002/diff/20001/snapshot/win/pe_image_r...
File snapshot/win/pe_image_reader.cc (right):

https://codereview.chromium.org/1527803002/diff/20001/snapshot/win/pe_image_r...
snapshot/win/pe_image_reader.cc:203: // Do two casts to make it explicit that we
are intentionally both converting
I don’t think the comment is necessary. Weird cast machinations like this are
always “avoid compiler bitterness” and this one’s pretty obvious.

https://codereview.chromium.org/1527803002/diff/20001/snapshot/win/pe_image_r...
snapshot/win/pe_image_reader.cc:206: const uint16_t type =
but I’d name it vs_file_info_type.

https://codereview.chromium.org/1527803002/diff/20001/util/util.gyp
File util/util.gyp (right):

https://codereview.chromium.org/1527803002/diff/20001/util/util.gyp#newcode262
util/util.gyp:262: 4577,  # 'noexcept' used with no exception handling mode
specified
Is there a macro that says that exceptions are off? We can key off of that and
#define CRASHPAD_NOEXCEPT empty in util/stdlib/aligned_allocator.h.

[brucedawson, 2015-12-15 00:00:57]

https://codereview.chromium.org/1527803002/diff/20001/snapshot/win/pe_image_r...
File snapshot/win/pe_image_reader.cc (right):

https://codereview.chromium.org/1527803002/diff/20001/snapshot/win/pe_image_r...
snapshot/win/pe_image_reader.cc:203: // Do two casts to make it explicit that we
are intentionally both converting
On 2015/12/14 23:51:30, Mark Mentovai wrote:
> I don’t think the comment is necessary. Weird cast machinations like this are
> always “avoid compiler bitterness” and this one’s pretty obvious.

Done.

https://codereview.chromium.org/1527803002/diff/20001/snapshot/win/pe_image_r...
snapshot/win/pe_image_reader.cc:206: const uint16_t type =
On 2015/12/14 23:51:30, Mark Mentovai wrote:
> but I’d name it vs_file_info_type.

Done.

https://codereview.chromium.org/1527803002/diff/20001/util/util.gyp
File util/util.gyp (right):

https://codereview.chromium.org/1527803002/diff/20001/util/util.gyp#newcode262
util/util.gyp:262: 4577,  # 'noexcept' used with no exception handling mode
specified
On 2015/12/14 23:51:30, Mark Mentovai wrote:
> Is there a macro that says that exceptions are off? We can key off of that and
> #define CRASHPAD_NOEXCEPT empty in util/stdlib/aligned_allocator.h.

We could do that, but it seems more fragile.
My impression is that we want to tell the compiler that no exceptions will be
thrown so that it can generate better code. The warning seems to be more related
to nothrow semantics where the compiler was required to enforce the semantics.

[Mark Mentovai, 2015-12-15 00:58:56]

LGTM

https://codereview.chromium.org/1527803002/diff/20001/util/util.gyp
File util/util.gyp (right):

https://codereview.chromium.org/1527803002/diff/20001/util/util.gyp#newcode262
util/util.gyp:262: 4577,  # 'noexcept' used with no exception handling mode
specified
brucedawson wrote:
> On 2015/12/14 23:51:30, Mark Mentovai wrote:
> > Is there a macro that says that exceptions are off? We can key off of that
and
> > #define CRASHPAD_NOEXCEPT empty in util/stdlib/aligned_allocator.h.
> 
> We could do that, but it seems more fragile.
> My impression is that we want to tell the compiler that no exceptions will be
> thrown so that it can generate better code. The warning seems to be more
related
> to nothrow semantics where the compiler was required to enforce the semantics.

I was thinking that it would take care of the GN build also, but it’s fine like
this too.

https://codereview.chromium.org/1527803002/diff/40001/snapshot/win/pe_image_r...
File snapshot/win/pe_image_reader.cc (right):

https://codereview.chromium.org/1527803002/diff/40001/snapshot/win/pe_image_r...
snapshot/win/pe_image_reader.cc:204:
static_cast<uint16_t>(reinterpret_cast<uintptr_t>(VS_FILE_INFO));
RT_VERSION belongs with this, since it’s the same as VS_FILE_INFO. I’ll fix for
check-in.

[Mark Mentovai, 2015-12-15 01:01:09]

Description was changed from

==========
Fix some VS 2015 warnings

Fix some warnings when compiling crashpad with VC++ 2015 Update 1.

Warning 4302 occurs if you convert from a pointer to a <sizeof(void*)
integer in one cast, because this often indicates an accidental pointer
truncation which can be a bug in 64-bit builds.

Warning 4577 warns that noexcept will not be enforced, but we don't want
it to be enforced anyway, so I disabled it. The full warning is:

warning C4577: 'noexcept' used with no exception handling mode specified
termination on exception is not guaranteed. Specify /EHsc

BUG=440500
==========

to

==========
Fix some VS 2015 warnings

Fix some warnings when compiling crashpad with VC++ 2015 Update 1.

Warning 4302 occurs if you convert from a pointer to a <sizeof(void*)
integer in one cast, because this often indicates an accidental pointer
truncation which can be a bug in 64-bit builds.

Warning 4577 warns that noexcept will not be enforced, but we don't want
it to be enforced anyway, so I disabled it. The full warning is:

warning C4577: 'noexcept' used with no exception handling mode specified
termination on exception is not guaranteed. Specify /EHsc

BUG=440500
R=mark@chromium.org

Committed:
https://chromium.googlesource.com/crashpad/crashpad/+/b0394744cc41a846eb9a79c...
==========

[Mark Mentovai, 2015-12-15 01:01:11]

Committed patchset #3 (id:40001) manually as
b0394744cc41a846eb9a79ccc73cd2992790ed42 (presubmit successful).