snapshot/win/pe_image_reader.cc - Issue 1527803002: Fix some VS 2015 warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: snapshot/win/pe_image_reader.cc

Issue 1527803002: Fix some VS 2015 warnings (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad.git@master

Patch Set: Remove comment and rename variable Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: snapshot/win/pe_image_reader.cc

diff --git a/snapshot/win/pe_image_reader.cc b/snapshot/win/pe_image_reader.cc

index 9abf0b139d4dce25cdeaae8e2a2372d16e6d3658..cf6133db173402e10c1aa5a5d44d67655e957acd 100644

--- a/snapshot/win/pe_image_reader.cc

+++ b/snapshot/win/pe_image_reader.cc

@@ -200,8 +200,10 @@ bool PEImageReader::VSFixedFileInfo(

WinVMAddress address;

WinVMSize size;

+ const uint16_t vs_file_info_type =

+ static_cast<uint16_t>(reinterpret_cast<uintptr_t>(VS_FILE_INFO));

Mark Mentovai 2015/12/15 00:58:56 RT_VERSION belongs with this, since it’s the same

if (!resource_reader.FindResourceByID(

- reinterpret_cast<uint16_t>(VS_FILE_INFO), // RT_VERSION

+ vs_file_info_type, // RT_VERSION

VS_VERSION_INFO,

MAKELANGID(LANG_NEUTRAL, SUBLANG_NEUTRAL),

&address,

« no previous file with comments | « no previous file | util/util.gyp » ('j') | no next file with comments »