Fix some VS 2015 warnings

snapshot/win/pe_image_reader.cc

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 182 matching lines @@
     return false;
   }
 
   PEImageResourceReader resource_reader;
   if (!resource_reader.Initialize(module_subrange_reader_, data_directory)) {
     return false;
   }
 
   WinVMAddress address;
   WinVMSize size;
+  // Do two casts to make it explicit that we are intentionally both converting

[Mark Mentovai, 2015/12/14 23:51:30]

I don’t think the comment is necessary. Weird cast machinations like this are
always “avoid compiler bitterness” and this one’s pretty obvious.

[brucedawson, 2015/12/15 00:00:56]

Done.

+  // from pointer to int, and doing a truncation. This avoids a VC++ 2015
+  // warning.
+  const uint16_t type =

[Mark Mentovai, 2015/12/14 23:51:30]

but I’d name it vs_file_info_type.

[brucedawson, 2015/12/15 00:00:56]

Done.

+      static_cast<uint16_t>(reinterpret_cast<uintptr_t>(VS_FILE_INFO));
   if (!resource_reader.FindResourceByID(
-          reinterpret_cast<uint16_t>(VS_FILE_INFO),  // RT_VERSION
+          type,  // RT_VERSION
           VS_VERSION_INFO,
           MAKELANGID(LANG_NEUTRAL, SUBLANG_NEUTRAL),
           &address,
           &size,
           nullptr)) {
     return false;
   }
 
   // This structure is not declared anywhere in the SDK, but is documented at
   // https://msdn.microsoft.com/en-us/library/windows/desktop/ms647001.aspx.
@@ skipping 161 matching lines @@
 // Explicit instantiations with the only 2 valid template arguments to avoid
 // putting the body of the function in the header.
 template bool PEImageReader::GetCrashpadInfo<process_types::internal::Traits32>(
     process_types::CrashpadInfo<process_types::internal::Traits32>*
         crashpad_info) const;
 template bool PEImageReader::GetCrashpadInfo<process_types::internal::Traits64>(
     process_types::CrashpadInfo<process_types::internal::Traits64>*
         crashpad_info) const;
 
 }  // namespace crashpad