[proxies] Improve error messages.

[proxies] Improve error messages.

This CL makes proxy-related error messages more accurate and verbose.
(Exception: those used in deprecated functions in v8natives.js.)  Some of
the old error messages were simply wrong.

On the side, fix ShouldThrow semantics of JSProxy::SetPrototype and
JSProxy::DefineOwnProperty.

R=cbruni@chromium.org, jkummerow@chromium.org
BUG=v8:1543
LOG=n

Committed: https://crrev.com/e960636571729b530cc24d56ccc27d09193df9d7
Cr-Commit-Position: refs/heads/master@{#32836}

[Jakob Kummerow, 2015-12-14 13:19:33]

LGTM with comment

https://codereview.chromium.org/1527583002/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1527583002/diff/20001/src/objects.cc#newcode6844
src/objects.cc:6844: NewTypeError(MessageTemplate::kProxyTrapReturnedFalsish,
...For

[Jakob Kummerow, 2015-12-14 13:19:53]

Description was changed from

==========
[proxies] Improve error messages.

This CL makes proxy-related error messages more accurate and verbose.
(Exception: those used in deprecated functions in v8natives.js.)  Some of
the old error messages were simply wrong.

On the side, fix ShouldThrow semantics of JSProxy::SetPrototype and
JSProxy::DefineOwnProperty.

R=cbruni@chromium.org, jkummerow@chromium.org
BUG=
==========

to

==========
[proxies] Improve error messages.

This CL makes proxy-related error messages more accurate and verbose.
(Exception: those used in deprecated functions in v8natives.js.)  Some of
the old error messages were simply wrong.

On the side, fix ShouldThrow semantics of JSProxy::SetPrototype and
JSProxy::DefineOwnProperty.

R=cbruni@chromium.org, jkummerow@chromium.org
BUG=v8:1543
LOG=n
==========

[neis, 2015-12-14 13:25:10]

The CQ bit was checked by neis@chromium.org

[neis, 2015-12-14 13:25:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1527583002/#ps40001
(title: "Address comment.")

[commit-bot: I haz the power, 2015-12-14 13:25:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1527583002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1527583002/40001

[commit-bot: I haz the power, 2015-12-14 13:44:57]

Description was changed from

==========
[proxies] Improve error messages.

This CL makes proxy-related error messages more accurate and verbose.
(Exception: those used in deprecated functions in v8natives.js.)  Some of
the old error messages were simply wrong.

On the side, fix ShouldThrow semantics of JSProxy::SetPrototype and
JSProxy::DefineOwnProperty.

R=cbruni@chromium.org, jkummerow@chromium.org
BUG=v8:1543
LOG=n
==========

to

==========
[proxies] Improve error messages.

This CL makes proxy-related error messages more accurate and verbose.
(Exception: those used in deprecated functions in v8natives.js.)  Some of
the old error messages were simply wrong.

On the side, fix ShouldThrow semantics of JSProxy::SetPrototype and
JSProxy::DefineOwnProperty.

R=cbruni@chromium.org, jkummerow@chromium.org
BUG=v8:1543
LOG=n
==========

[commit-bot: I haz the power, 2015-12-14 13:44:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-14 13:45:08]

Description was changed from

==========
[proxies] Improve error messages.

This CL makes proxy-related error messages more accurate and verbose.
(Exception: those used in deprecated functions in v8natives.js.)  Some of
the old error messages were simply wrong.

On the side, fix ShouldThrow semantics of JSProxy::SetPrototype and
JSProxy::DefineOwnProperty.

R=cbruni@chromium.org, jkummerow@chromium.org
BUG=v8:1543
LOG=n
==========

to

==========
[proxies] Improve error messages.

This CL makes proxy-related error messages more accurate and verbose.
(Exception: those used in deprecated functions in v8natives.js.)  Some of
the old error messages were simply wrong.

On the side, fix ShouldThrow semantics of JSProxy::SetPrototype and
JSProxy::DefineOwnProperty.

R=cbruni@chromium.org, jkummerow@chromium.org
BUG=v8:1543
LOG=n

Committed: https://crrev.com/e960636571729b530cc24d56ccc27d09193df9d7
Cr-Commit-Position: refs/heads/master@{#32836}
==========

[commit-bot: I haz the power, 2015-12-14 13:45:09]

Patchset 3 (id:??) landed as
https://crrev.com/e960636571729b530cc24d56ccc27d09193df9d7
Cr-Commit-Position: refs/heads/master@{#32836}