Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Side by Side Diff: src/objects.h

Issue 1527583002: [proxies] Improve error messages. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address comment. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/messages.h ('k') | src/objects.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_OBJECTS_H_ 5 #ifndef V8_OBJECTS_H_
6 #define V8_OBJECTS_H_ 6 #define V8_OBJECTS_H_
7 7
8 #include <iosfwd> 8 #include <iosfwd>
9 9
10 #include "src/allocation.h" 10 #include "src/allocation.h"
(...skipping 1829 matching lines...) Expand 10 before | Expand all | Expand 10 after
1840 1840
1841 // ES6 9.1.6.1 1841 // ES6 9.1.6.1
1842 MUST_USE_RESULT static Maybe<bool> OrdinaryDefineOwnProperty( 1842 MUST_USE_RESULT static Maybe<bool> OrdinaryDefineOwnProperty(
1843 Isolate* isolate, Handle<JSObject> object, Handle<Object> key, 1843 Isolate* isolate, Handle<JSObject> object, Handle<Object> key,
1844 PropertyDescriptor* desc, ShouldThrow should_throw); 1844 PropertyDescriptor* desc, ShouldThrow should_throw);
1845 MUST_USE_RESULT static Maybe<bool> OrdinaryDefineOwnProperty( 1845 MUST_USE_RESULT static Maybe<bool> OrdinaryDefineOwnProperty(
1846 LookupIterator* it, PropertyDescriptor* desc, ShouldThrow should_throw); 1846 LookupIterator* it, PropertyDescriptor* desc, ShouldThrow should_throw);
1847 // ES6 9.1.6.2 1847 // ES6 9.1.6.2
1848 MUST_USE_RESULT static Maybe<bool> IsCompatiblePropertyDescriptor( 1848 MUST_USE_RESULT static Maybe<bool> IsCompatiblePropertyDescriptor(
1849 Isolate* isolate, bool extensible, PropertyDescriptor* desc, 1849 Isolate* isolate, bool extensible, PropertyDescriptor* desc,
1850 PropertyDescriptor* current, Handle<Name> property_name); 1850 PropertyDescriptor* current, Handle<Name> property_name,
1851 ShouldThrow should_throw);
1851 // ES6 9.1.6.3 1852 // ES6 9.1.6.3
1852 // |it| can be NULL in cases where the ES spec passes |undefined| as the 1853 // |it| can be NULL in cases where the ES spec passes |undefined| as the
1853 // receiver. Exactly one of |it| and |property_name| must be provided. 1854 // receiver. Exactly one of |it| and |property_name| must be provided.
1854 MUST_USE_RESULT static Maybe<bool> ValidateAndApplyPropertyDescriptor( 1855 MUST_USE_RESULT static Maybe<bool> ValidateAndApplyPropertyDescriptor(
1855 Isolate* isolate, LookupIterator* it, bool extensible, 1856 Isolate* isolate, LookupIterator* it, bool extensible,
1856 PropertyDescriptor* desc, PropertyDescriptor* current, 1857 PropertyDescriptor* desc, PropertyDescriptor* current,
1857 ShouldThrow should_throw, Handle<Name> property_name = Handle<Name>()); 1858 ShouldThrow should_throw, Handle<Name> property_name = Handle<Name>());
1858 1859
1859 MUST_USE_RESULT static Maybe<bool> GetOwnPropertyDescriptor( 1860 MUST_USE_RESULT static Maybe<bool> GetOwnPropertyDescriptor(
1860 Isolate* isolate, Handle<JSReceiver> object, Handle<Object> key, 1861 Isolate* isolate, Handle<JSReceiver> object, Handle<Object> key,
(...skipping 8842 matching lines...) Expand 10 before | Expand all | Expand 10 after
10703 } 10704 }
10704 return value; 10705 return value;
10705 } 10706 }
10706 }; 10707 };
10707 10708
10708 10709
10709 } // NOLINT, false-positive due to second-order macros. 10710 } // NOLINT, false-positive due to second-order macros.
10710 } // NOLINT, false-positive due to second-order macros. 10711 } // NOLINT, false-positive due to second-order macros.
10711 10712
10712 #endif // V8_OBJECTS_H_ 10713 #endif // V8_OBJECTS_H_
OLDNEW
« no previous file with comments | « src/messages.h ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698