src/objects.h - Issue 1527583002: [proxies] Improve error messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.h

Issue 1527583002: [proxies] Improve error messages. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address comment. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.h

diff --git a/src/objects.h b/src/objects.h

index 9e20a12cd2b2ba2ac34e94364723b04094f4251f..bdc484dfd4b3746a566861cb1666c73248168f2f 100644

--- a/src/objects.h

+++ b/src/objects.h

@@ -1847,7 +1847,8 @@ class JSReceiver: public HeapObject {

// ES6 9.1.6.2

MUST_USE_RESULT static Maybe<bool> IsCompatiblePropertyDescriptor(

Isolate* isolate, bool extensible, PropertyDescriptor* desc,

- PropertyDescriptor* current, Handle<Name> property_name);

+ PropertyDescriptor* current, Handle<Name> property_name,

+ ShouldThrow should_throw);

// ES6 9.1.6.3

// |it| can be NULL in cases where the ES spec passes |undefined| as the

// receiver. Exactly one of |it| and |property_name| must be provided.

« no previous file with comments | « src/messages.h ('k') | src/objects.cc » ('j') | no next file with comments »