Generate a table of config->glformat info. Precursor to lifting this to caps.

Generate a table of config->glformat info. Precursor to lifting this to caps.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1527383003

Committed: https://skia.googlesource.com/skia/+/54c6fe8519f2927181a0847d22a61190529645e8

[bsalomon, 2015-12-16 19:08:05]

Description was changed from

==========
Generate a table of config->glformat info. Precursor to lifting this caps.
==========

to

==========
Generate a table of config->glformat info. Precursor to lifting this caps.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2015-12-16 19:10:44]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com, robertphillips@google.com

[bsalomon, 2015-12-16 19:10:45]

https://codereview.chromium.org/1527383003/diff/1/src/gpu/gl/GrGLDefines.h
File src/gpu/gl/GrGLDefines.h (right):

https://codereview.chromium.org/1527383003/diff/1/src/gpu/gl/GrGLDefines.h#ne...
src/gpu/gl/GrGLDefines.h:288: #define GR_GL_COMPRESSED_RGBA_ASTC_4x4            
    0x93B0
We don't usually include vendor suffixes on extension macros unless required to
disambiguate two macros with the same name but different values.

https://codereview.chromium.org/1527383003/diff/1/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1527383003/diff/1/src/gpu/gl/GrGLGpu.cpp#newc...
src/gpu/gl/GrGLGpu.cpp:2687: void GrGLGpu::generateConfigTable() {
This function mirrors the logic of the old configToGLFormats but just saves the
answers in a table.

https://codereview.chromium.org/1527383003/diff/1/src/gpu/gl/GrGLGpu.h
File src/gpu/gl/GrGLGpu.h (right):

https://codereview.chromium.org/1527383003/diff/1/src/gpu/gl/GrGLGpu.h#newcod...
src/gpu/gl/GrGLGpu.h:514: SkTArray<uint32_t, true>    fHWBoundTextureUniqueIDs;
just moved this stuff to be within the ///@} below.

[bsalomon, 2015-12-16 19:10:49]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-16 19:10:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1527383003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1527383003/1

[bsalomon, 2015-12-16 19:11:04]

Description was changed from

==========
Generate a table of config->glformat info. Precursor to lifting this caps.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Generate a table of config->glformat info. Precursor to lifting this to caps.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[egdaniel, 2015-12-16 19:19:09]

https://codereview.chromium.org/1527383003/diff/1/src/gpu/gl/GrGLGpu.h
File src/gpu/gl/GrGLGpu.h (right):

https://codereview.chromium.org/1527383003/diff/1/src/gpu/gl/GrGLGpu.h#newcod...
src/gpu/gl/GrGLGpu.h:551: ConfigEntry fConfigTable[kLast_GrPixelConfig + 1];
Why not have this configTable live on the caps instead of the gpu. Seems to be a
better place for this kind of logic.

[bsalomon, 2015-12-16 19:21:20]

https://codereview.chromium.org/1527383003/diff/1/src/gpu/gl/GrGLGpu.h
File src/gpu/gl/GrGLGpu.h (right):

https://codereview.chromium.org/1527383003/diff/1/src/gpu/gl/GrGLGpu.h#newcod...
src/gpu/gl/GrGLGpu.h:551: ConfigEntry fConfigTable[kLast_GrPixelConfig + 1];
On 2015/12/16 19:19:08, egdaniel wrote:
> Why not have this configTable live on the caps instead of the gpu. Seems to be
a
> better place for this kind of logic.

Yes, as noted in description, this is the first step of that.

[commit-bot: I haz the power, 2015-12-16 19:26:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-16 19:26:53]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2015-12-16 19:35:59]

lgtm

[bsalomon, 2015-12-16 19:50:40]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2015-12-16 19:50:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1527383003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1527383003/1

[commit-bot: I haz the power, 2015-12-16 19:51:25]

Description was changed from

==========
Generate a table of config->glformat info. Precursor to lifting this to caps.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Generate a table of config->glformat info. Precursor to lifting this to caps.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/54c6fe8519f2927181a0847d22a61190529645e8
==========

[commit-bot: I haz the power, 2015-12-16 19:51:25]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/54c6fe8519f2927181a0847d22a61190529645e8