Fix a leak in TestingJsonParser.

Fix a leak in TestingJsonParser.

This can occur if the Parse() completion callback quits the run loop, since the
parser is freed using DeleteSoon() in a task posted after the callbacks.

Committed: https://crrev.com/5ab681bdaf33de3e075ebdc3e84ab91640655f47
Cr-Commit-Position: refs/heads/master@{#365539}

[Robert Sesek, 2015-12-15 19:28:41]

Patchset #1 (id:1) has been deleted

[Robert Sesek, 2015-12-15 20:44:35]

Description was changed from

==========
Test leak in TestingJsonParser.

BUG=
==========

to

==========
Fix a leak in TestingJsonParser.

This can occur if the Parse() completion callback quits the run loop, since the
parser freed using DeleteSoon() in a task posted after the callbacks.
==========

[Robert Sesek, 2015-12-15 20:45:07]

Description was changed from

==========
Fix a leak in TestingJsonParser.

This can occur if the Parse() completion callback quits the run loop, since the
parser freed using DeleteSoon() in a task posted after the callbacks.
==========

to

==========
Fix a leak in TestingJsonParser.

This can occur if the Parse() completion callback quits the run loop, since the
parser freed using DeleteSoon() in a task posted after the callbacks.
==========

[Robert Sesek, 2015-12-15 20:50:00]

rsesek@chromium.org changed reviewers:
+ bauerb@chromium.org

[Robert Sesek, 2015-12-15 20:50:01]

First patch set has a trybot showing the leak, second fixes it.

[Robert Sesek, 2015-12-16 00:34:34]

Description was changed from

==========
Fix a leak in TestingJsonParser.

This can occur if the Parse() completion callback quits the run loop, since the
parser freed using DeleteSoon() in a task posted after the callbacks.
==========

to

==========
Fix a leak in TestingJsonParser.

This can occur if the Parse() completion callback quits the run loop, since the
parser is freed using DeleteSoon() in a task posted after the callbacks.
==========

[Bernhard Bauer, 2015-12-16 08:48:00]

LGTM, thanks!

https://codereview.chromium.org/1527063002/diff/40001/components/safe_json/te...
File components/safe_json/testing_json_parser.cc (left):

https://codereview.chromium.org/1527063002/diff/40001/components/safe_json/te...
components/safe_json/testing_json_parser.cc:55:
base::MessageLoop::current()->DeleteSoon(FROM_HERE, this);
Hm… in principle we could also delete this object directly here, no? No one else
has a pointer to it anyway.

[Robert Sesek, 2015-12-16 15:55:50]

https://codereview.chromium.org/1527063002/diff/40001/components/safe_json/te...
File components/safe_json/testing_json_parser.cc (left):

https://codereview.chromium.org/1527063002/diff/40001/components/safe_json/te...
components/safe_json/testing_json_parser.cc:55:
base::MessageLoop::current()->DeleteSoon(FROM_HERE, this);
On 2015/12/16 08:48:00, Bernhard Bauer wrote:
> Hm… in principle we could also delete this object directly here, no? No one
else
> has a pointer to it anyway.

Yeah, that's true, but there's no real difference from this, though.

[Robert Sesek, 2015-12-16 15:55:57]

The CQ bit was checked by rsesek@chromium.org

[commit-bot: I haz the power, 2015-12-16 15:56:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1527063002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1527063002/40001

[commit-bot: I haz the power, 2015-12-16 16:25:46]

Description was changed from

==========
Fix a leak in TestingJsonParser.

This can occur if the Parse() completion callback quits the run loop, since the
parser is freed using DeleteSoon() in a task posted after the callbacks.
==========

to

==========
Fix a leak in TestingJsonParser.

This can occur if the Parse() completion callback quits the run loop, since the
parser is freed using DeleteSoon() in a task posted after the callbacks.
==========

[commit-bot: I haz the power, 2015-12-16 16:25:46]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-12-16 16:27:39]

Description was changed from

==========
Fix a leak in TestingJsonParser.

This can occur if the Parse() completion callback quits the run loop, since the
parser is freed using DeleteSoon() in a task posted after the callbacks.
==========

to

==========
Fix a leak in TestingJsonParser.

This can occur if the Parse() completion callback quits the run loop, since the
parser is freed using DeleteSoon() in a task posted after the callbacks.

Committed: https://crrev.com/5ab681bdaf33de3e075ebdc3e84ab91640655f47
Cr-Commit-Position: refs/heads/master@{#365539}
==========

[commit-bot: I haz the power, 2015-12-16 16:27:40]

Patchset 2 (id:??) landed as
https://crrev.com/5ab681bdaf33de3e075ebdc3e84ab91640655f47
Cr-Commit-Position: refs/heads/master@{#365539}