Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: components/safe_json/testing_json_parser_unittest.cc

Issue 1527063002: Fix a leak in TestingJsonParser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: With fix Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_json/testing_json_parser_unittest.cc
diff --git a/components/safe_json/testing_json_parser_unittest.cc b/components/safe_json/testing_json_parser_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..20ad641346631004109d3c728aa7c8b21179e69d
--- /dev/null
+++ b/components/safe_json/testing_json_parser_unittest.cc
@@ -0,0 +1,77 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/safe_json/testing_json_parser.h"
+
+#include "base/bind.h"
+#include "base/callback.h"
+#include "base/message_loop/message_loop.h"
+#include "base/run_loop.h"
+#include "base/values.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace safe_json {
+namespace {
+
+const char kTestJson[] = "{\"key\":2}";
+
+class TestingJsonParserTest : public testing::Test {
+ public:
+ void Parse(const std::string& input) {
+ base::RunLoop run_loop;
+ SafeJsonParser::Parse(input,
+ base::Bind(&SuccessCallback, base::Unretained(this),
+ run_loop.QuitClosure()),
+ base::Bind(&ErrorCallback, base::Unretained(this),
+ run_loop.QuitClosure()));
+ run_loop.Run();
+ }
+
+ bool did_success() { return did_success_; }
+ bool did_error() { return did_error_; }
+
+ private:
+ static void SuccessCallback(TestingJsonParserTest* test,
+ base::Closure quit_closure,
+ scoped_ptr<base::Value> value) {
+ test->did_success_ = true;
+ quit_closure.Run();
+
+ ASSERT_TRUE(value->IsType(base::Value::TYPE_DICTIONARY));
+ base::DictionaryValue* dict;
+ ASSERT_TRUE(value->GetAsDictionary(&dict));
+ int key_value = 0;
+ EXPECT_TRUE(dict->GetInteger("key", &key_value));
+ EXPECT_EQ(2, key_value);
+ }
+
+ static void ErrorCallback(TestingJsonParserTest* test,
+ base::Closure quit_closure,
+ const std::string& error) {
+ test->did_error_ = true;
+ quit_closure.Run();
+
+ EXPECT_FALSE(error.empty());
+ }
+
+ base::MessageLoop message_loop;
+ TestingJsonParser::ScopedFactoryOverride factory_override_;
+ bool did_success_ = false;
+ bool did_error_ = false;
+};
+
+TEST_F(TestingJsonParserTest, QuitLoopInSuccessCallback) {
+ Parse(kTestJson);
+ EXPECT_TRUE(did_success());
+ EXPECT_FALSE(did_error());
+}
+
+TEST_F(TestingJsonParserTest, QuitLoopInErrorCallback) {
+ Parse(&kTestJson[1]);
+ EXPECT_FALSE(did_success());
+ EXPECT_TRUE(did_error());
+}
+
+} // namespace
+} // namespace safe_json
« components/safe_json/testing_json_parser.cc ('K') | « components/safe_json/testing_json_parser.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698