[Extensions] Don't use ExtensionInstallPrompt subclasses for auto-confirmation

[Extensions] Don't use ExtensionInstallPrompt subclasses for auto-confirmation

There's a ScopedTestDialogAutoConfirm object that the ExtensionInstallPrompt
checks in order to perform auto acceptance/cancelation.  This is a lot simpler
than subclassing the entire dialog, and results in more consistent test
behavior. Use it in the place of subclasses when possible.

BUG=570021
TBR=rdsmith@chromium.org (mechanical c/b/download changes)

Committed: https://crrev.com/ca5bf2da38ae9e4c3e8c6278805a95caf7128add
Cr-Commit-Position: refs/heads/master@{#365884}

[Devlin, 2015-12-15 20:59:36]

Description was changed from

==========
foo

BUG=
==========

to

==========
[Extensions] Don't use ExtensionInstallPrompt subclasses for auto-confirmation

There's a ScopedTestDialogAutoConfirm object that the ExtensionInstallPrompt
checks in order to perform auto acceptance/cancelation.  This is a lot simpler
than subclassing the entire dialog, and results in more consistent test
behavior. Use it in the place of subclasses when possible.

BUG=570021
==========

[Devlin, 2015-12-15 22:11:49]

Patchset #1 (id:1) has been deleted

[Devlin, 2015-12-15 22:12:00]

rdevlin.cronin@chromium.org changed reviewers:
+ asargent@chromium.org

[asargent_no_longer_on_chrome, 2015-12-15 23:29:53]

nice, lgtm

[Devlin, 2015-12-17 19:48:18]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2015-12-17 19:48:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/1527043002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2015-12-17 19:49:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1527043002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1527043002/60001

[commit-bot: I haz the power, 2015-12-17 20:52:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-17 20:52:23]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Devlin, 2015-12-17 21:07:24]

Description was changed from

==========
[Extensions] Don't use ExtensionInstallPrompt subclasses for auto-confirmation

There's a ScopedTestDialogAutoConfirm object that the ExtensionInstallPrompt
checks in order to perform auto acceptance/cancelation.  This is a lot simpler
than subclassing the entire dialog, and results in more consistent test
behavior. Use it in the place of subclasses when possible.

BUG=570021
==========

to

==========
[Extensions] Don't use ExtensionInstallPrompt subclasses for auto-confirmation

There's a ScopedTestDialogAutoConfirm object that the ExtensionInstallPrompt
checks in order to perform auto acceptance/cancelation.  This is a lot simpler
than subclassing the entire dialog, and results in more consistent test
behavior. Use it in the place of subclasses when possible.

BUG=570021
TBR=rdsmith@chromium.org (mechanical c/b/download changes)
==========

[Devlin, 2015-12-17 21:07:30]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2015-12-17 21:08:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1527043002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1527043002/60001

[commit-bot: I haz the power, 2015-12-17 21:21:19]

Description was changed from

==========
[Extensions] Don't use ExtensionInstallPrompt subclasses for auto-confirmation

There's a ScopedTestDialogAutoConfirm object that the ExtensionInstallPrompt
checks in order to perform auto acceptance/cancelation.  This is a lot simpler
than subclassing the entire dialog, and results in more consistent test
behavior. Use it in the place of subclasses when possible.

BUG=570021
TBR=rdsmith@chromium.org (mechanical c/b/download changes)
==========

to

==========
[Extensions] Don't use ExtensionInstallPrompt subclasses for auto-confirmation

There's a ScopedTestDialogAutoConfirm object that the ExtensionInstallPrompt
checks in order to perform auto acceptance/cancelation.  This is a lot simpler
than subclassing the entire dialog, and results in more consistent test
behavior. Use it in the place of subclasses when possible.

BUG=570021
TBR=rdsmith@chromium.org (mechanical c/b/download changes)
==========

[commit-bot: I haz the power, 2015-12-17 21:21:20]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-12-17 21:22:17]

Description was changed from

==========
[Extensions] Don't use ExtensionInstallPrompt subclasses for auto-confirmation

There's a ScopedTestDialogAutoConfirm object that the ExtensionInstallPrompt
checks in order to perform auto acceptance/cancelation.  This is a lot simpler
than subclassing the entire dialog, and results in more consistent test
behavior. Use it in the place of subclasses when possible.

BUG=570021
TBR=rdsmith@chromium.org (mechanical c/b/download changes)
==========

to

==========
[Extensions] Don't use ExtensionInstallPrompt subclasses for auto-confirmation

There's a ScopedTestDialogAutoConfirm object that the ExtensionInstallPrompt
checks in order to perform auto acceptance/cancelation.  This is a lot simpler
than subclassing the entire dialog, and results in more consistent test
behavior. Use it in the place of subclasses when possible.

BUG=570021
TBR=rdsmith@chromium.org (mechanical c/b/download changes)

Committed: https://crrev.com/ca5bf2da38ae9e4c3e8c6278805a95caf7128add
Cr-Commit-Position: refs/heads/master@{#365884}
==========

[commit-bot: I haz the power, 2015-12-17 21:22:18]

Patchset 3 (id:??) landed as
https://crrev.com/ca5bf2da38ae9e4c3e8c6278805a95caf7128add
Cr-Commit-Position: refs/heads/master@{#365884}