[Extensions] Don't use ExtensionInstallPrompt subclasses for auto-confirmation

chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/extensions/extension_settings_browsertest.h"
 
 #include "base/files/file_path.h"
 #include "base/path_service.h"
 #include "base/strings/string_number_conversions.h"
 #include "chrome/browser/chrome_notification_types.h"
@@ skipping 96 matching lines @@
       extensions::FeatureSwitch::error_console(), true));
 }
 
 void ExtensionSettingsUIBrowserTest::ShrinkWebContentsView() {
   content::WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   CHECK(web_contents);
   ResizeWebContents(web_contents, gfx::Size(400, 400));
 }
 
-class MockAutoConfirmExtensionInstallPrompt : public ExtensionInstallPrompt {
- public:
-  explicit MockAutoConfirmExtensionInstallPrompt(
-      content::WebContents* web_contents)
-    : ExtensionInstallPrompt(web_contents) {}
-
-  // Proceed without confirmation prompt.
-  void ShowDialog(Delegate* delegate,
-                  const Extension* extension,
-                  const SkBitmap* icon,
-                  const ShowDialogCallback& show_dialog_callback) override {
-    delegate->InstallUIProceed();
-  }
-};
-
 const Extension* ExtensionSettingsUIBrowserTest::InstallUnpackedExtension(
     const base::FilePath& path) {
   if (path.empty())
     return nullptr;
 
   Profile* profile = GetProfile();
   ExtensionService* service =
       extensions::ExtensionSystem::Get(profile)->extension_service();
   service->set_show_extensions_prompts(false);
   extensions::ExtensionRegistry* registry =
@@ skipping 12 matching lines @@
 const Extension* ExtensionSettingsUIBrowserTest::InstallExtension(
     const base::FilePath& path) {
   Profile* profile = GetProfile();
   ExtensionService* service =
       extensions::ExtensionSystem::Get(profile)->extension_service();
   extensions::ExtensionRegistry* registry =
       extensions::ExtensionRegistry::Get(profile);
   service->set_show_extensions_prompts(false);
   size_t num_before = registry->enabled_extensions().size();
   {
-    scoped_ptr<ExtensionInstallPrompt> install_ui;
-    install_ui.reset(new MockAutoConfirmExtensionInstallPrompt(
-        browser()->tab_strip_model()->GetActiveWebContents()));
+    extensions::ScopedTestDialogAutoConfirm auto_confirm(
+        extensions::ScopedTestDialogAutoConfirm::ACCEPT);
+    scoped_ptr<ExtensionInstallPrompt> install_ui(
+        new ExtensionInstallPrompt(
+            browser()->tab_strip_model()->GetActiveWebContents()));
 
     base::FilePath crx_path = path;
     DCHECK(crx_path.Extension() == FILE_PATH_LITERAL(".crx"));
     if (crx_path.empty())
       return nullptr;
 
     scoped_refptr<extensions::CrxInstaller> installer(
         extensions::CrxInstaller::Create(service, install_ui.Pass()));
     installer->set_expected_id(std::string());
     installer->set_is_gallery_install(false);
@@ skipping 28 matching lines @@
          iter != errors->end(); ++iter)
       VLOG(1) << *iter;
 
     return nullptr;
   }
 
   if (!observer_->WaitForExtensionViewsToLoad())
     return nullptr;
   return service->GetExtensionById(last_loaded_extension_id(), false);
 }