[Extensions] Don't use ExtensionInstallPrompt subclasses for auto-confirmation

chrome/browser/extensions/extension_install_prompt.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_INSTALL_PROMPT_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_INSTALL_PROMPT_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 304 matching lines @@
   // show.
   // |extension| can be null in the case of a bndle install.
   // If |icon| is null, this will attempt to load the extension's icon.
   // |prompt| is used to pass in a prompt with additional data (like retained
   // device permissions) or a different type. If not provided, |prompt| will
   // be created as an INSTALL_PROMPT.
   // |custom_permissions| will be used if provided; otherwise, the extensions
   // current permissions are used.
   //
   // We *MUST* eventually call either Proceed() or Abort() on |delegate|.
-  virtual void ShowDialog(Delegate* delegate,
-                          const extensions::Extension* extension,
-                          const SkBitmap* icon,
-                          const ShowDialogCallback& show_dialog_callback);
-  virtual void ShowDialog(Delegate* delegate,
-                          const extensions::Extension* extension,
-                          const SkBitmap* icon,
-                          scoped_ptr<Prompt> prompt,
-                          const ShowDialogCallback& show_dialog_callback);
+  void ShowDialog(Delegate* delegate,
+                  const extensions::Extension* extension,
+                  const SkBitmap* icon,
+                  const ShowDialogCallback& show_dialog_callback);
+  void ShowDialog(Delegate* delegate,
+                  const extensions::Extension* extension,
+                  const SkBitmap* icon,
+                  scoped_ptr<Prompt> prompt,
+                  const ShowDialogCallback& show_dialog_callback);
+  // Declared virtual for testing purposes.
+  // Note: if all you want to do is automatically confirm or cancel, prefer
+  // ScopedTestDialogAutoConfirm from extension_dialog_auto_confirm.h
   virtual void ShowDialog(
       Delegate* delegate,
       const extensions::Extension* extension,
       const SkBitmap* icon,
       scoped_ptr<Prompt> prompt,
       scoped_ptr<const extensions::PermissionSet> custom_permissions,
       const ShowDialogCallback& show_dialog_callback);
 
   // Installation was successful. This is declared virtual for testing.
   virtual void OnInstallSuccess(const extensions::Extension* extension,
                                 SkBitmap* icon);
 
   // Installation failed. This is declared virtual for testing.
   virtual void OnInstallFailure(const extensions::CrxInstallError& error);
 
+  bool did_call_show_dialog() const { return did_call_show_dialog_; }
+
  protected:
   friend class extensions::ExtensionWebstorePrivateApiTest;
   friend class WebstoreStartupInstallUnpackFailureTest;
 
  private:
   friend class GalleryInstallApiTestObserver;
 
   // Sets the icon that will be used in any UI. If |icon| is NULL, or contains
   // an empty bitmap, then a default icon will be used instead.
   void SetIcon(const SkBitmap* icon);
@@ skipping 32 matching lines @@
 
   // The delegate we will call Proceed/Abort on after confirmation UI.
   Delegate* delegate_;
 
   // A pre-filled prompt.
   scoped_ptr<Prompt> prompt_;
 
   // Used to show the confirm dialog.
   ShowDialogCallback show_dialog_callback_;
 
+  // Whether or not the |show_dialog_callback_| was called.
+  bool did_call_show_dialog_;
+
   DISALLOW_COPY_AND_ASSIGN(ExtensionInstallPrompt);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_INSTALL_PROMPT_H_