Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1527023002: Add unit test for disabling deferred canvas rendering while hibernating (Closed)

Created:
5 years ago by Justin Novosad
Modified:
5 years ago
Reviewers:
Stephen White
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, ajuma+watch-canvas_chromium.org, dshwang, jbroman, Justin Novosad, danakj, blink-reviews-platform-graphics_chromium.org, Rik, f(malita), blink-reviews, vmpstr+blinkwatch_chromium.org, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add unit test for disabling deferred canvas rendering while hibernating Crash was already inavertently fixed by https://codereview.chromium.org/1520123002/ This change adds a test that would have caught the crash in the first place. BUG=568583 Committed: https://crrev.com/8386f2d54fd8f9f62047b6002d3c9743ab3bcfeb Cr-Commit-Position: refs/heads/master@{#365326}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -1 line) Patch
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp View 2 chunks +59 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
Justin Novosad
PTAL
5 years ago (2015-12-15 18:34:09 UTC) #2
Stephen White
LGTM
5 years ago (2015-12-15 19:05:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1527023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1527023002/1
5 years ago (2015-12-15 19:09:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 21:28:50 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-15 21:30:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8386f2d54fd8f9f62047b6002d3c9743ab3bcfeb
Cr-Commit-Position: refs/heads/master@{#365326}

Powered by Google App Engine
This is Rietveld 408576698