Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Unified Diff: third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp

Issue 1527023002: Add unit test for disabling deferred canvas rendering while hibernating (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp b/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp
index 64cb48ffb248931a3190e888e0753237f4f440f8..859b612f74a5283d8c8fb8c5f25c192547d10e8b 100644
--- a/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp
+++ b/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp
@@ -646,7 +646,6 @@ TEST_F(Canvas2DLayerBridgeTest, BackgroundRenderingWhileHibernatingWithDeferredR
bridge->setImageBuffer(&mockImageBuffer);
bridge->disableDeferral();
-
// Register an alternate Logger for tracking hibernation events
OwnPtr<MockLogger> mockLogger = adoptPtr(new MockLogger);
MockLogger* mockLoggerPtr = mockLogger.get();
@@ -693,6 +692,65 @@ TEST_F(Canvas2DLayerBridgeTest, BackgroundRenderingWhileHibernatingWithDeferredR
bridgeDestroyedEvent->wait();
}
+TEST_F(Canvas2DLayerBridgeTest, DisableDeferredRenderingWhileHibernating)
+{
+ MockCanvasContext mainMock;
+ OwnPtr<WebThread> testThread = adoptPtr(Platform::current()->createThread("TestThread"));
+
+ // The Canvas2DLayerBridge has to be created on the thread that will use it
+ // to avoid WeakPtr thread check issues.
+ Canvas2DLayerBridgePtr bridge;
+ OwnPtr<WebWaitableEvent> bridgeCreatedEvent = adoptPtr(Platform::current()->createWaitableEvent());
+ testThread->taskRunner()->postTask(BLINK_FROM_HERE, new CreateBridgeTask(&bridge, &mainMock, this, bridgeCreatedEvent.get()));
+ bridgeCreatedEvent->wait();
+ MockImageBuffer mockImageBuffer;
+ EXPECT_CALL(mockImageBuffer, resetCanvas(_)).Times(AnyNumber());
+ bridge->setImageBuffer(&mockImageBuffer);
+
+ // Register an alternate Logger for tracking hibernation events
+ OwnPtr<MockLogger> mockLogger = adoptPtr(new MockLogger);
+ MockLogger* mockLoggerPtr = mockLogger.get();
+ bridge->setLoggerForTesting(mockLogger.release());
+
+ // Test entering hibernation
+ OwnPtr<WebWaitableEvent> hibernationStartedEvent = adoptPtr(Platform::current()->createWaitableEvent());
+ EXPECT_CALL(*mockLoggerPtr, reportHibernationEvent(Canvas2DLayerBridge::HibernationScheduled));
+ EXPECT_CALL(*mockLoggerPtr, didStartHibernating())
+ .WillOnce(testing::Invoke(hibernationStartedEvent.get(), &WebWaitableEvent::signal));
+ testThread->taskRunner()->postTask(BLINK_FROM_HERE, new SetIsHiddenTask(bridge.get(), true));
+ hibernationStartedEvent->wait();
+ ::testing::Mock::VerifyAndClearExpectations(mockLoggerPtr);
+ ::testing::Mock::VerifyAndClearExpectations(&mockImageBuffer);
+ EXPECT_FALSE(bridge->isAccelerated());
+ EXPECT_TRUE(bridge->isHibernating());
+
+ // Disable deferral while background rendering
+ EXPECT_CALL(*mockLoggerPtr, reportHibernationEvent(Canvas2DLayerBridge::HibernationEndedWithSwitchToBackgroundRendering));
+ EXPECT_CALL(mockImageBuffer, resetCanvas(_)).Times(AtLeast(1));
+ bridge->disableDeferral();
+ ::testing::Mock::VerifyAndClearExpectations(mockLoggerPtr);
+ ::testing::Mock::VerifyAndClearExpectations(&mockImageBuffer);
+ EXPECT_FALSE(bridge->isAccelerated());
+ EXPECT_FALSE(bridge->isHibernating());
+
+ // Unhide
+ EXPECT_CALL(mockImageBuffer, resetCanvas(_)).Times(AtLeast(1));
+ OwnPtr<WebWaitableEvent> unhideEvent = adoptPtr(Platform::current()->createWaitableEvent());
+ testThread->taskRunner()->postTask(BLINK_FROM_HERE, new SetIsHiddenTask(bridge.get(), false, unhideEvent.get()));
+ unhideEvent->wait();
+ ::testing::Mock::VerifyAndClearExpectations(mockLoggerPtr);
+ ::testing::Mock::VerifyAndClearExpectations(&mockImageBuffer);
+ EXPECT_TRUE(bridge->isAccelerated()); // Becoming visible causes switch back to GPU
+ EXPECT_FALSE(bridge->isHibernating());
+
+ // Tear down the bridge on the thread so that 'bridge' can go out of scope
+ // without crashing due to thread checks
+ EXPECT_CALL(mockImageBuffer, resetCanvas(_)).Times(AnyNumber());
+ OwnPtr<WebWaitableEvent> bridgeDestroyedEvent = adoptPtr(Platform::current()->createWaitableEvent());
+ testThread->taskRunner()->postTask(BLINK_FROM_HERE, new DestroyBridgeTask(&bridge, bridgeDestroyedEvent.get()));
+ bridgeDestroyedEvent->wait();
+}
+
TEST_F(Canvas2DLayerBridgeTest, TeardownWhileHibernating)
{
MockCanvasContext mainMock;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698