Associate compile-time errors with elements

pkg/compiler/lib/src/js_backend/backend.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of js_backend;
 
 const VERBOSE_OPTIMIZER_HINTS = false;
 
 class JavaScriptItemCompilationContext extends ItemCompilationContext {
   final Set<HInstruction> boundsChecked = new Set<HInstruction>();
@@ skipping 1547 matching lines @@
     for (ClassElement cls in impact.instantiatedClasses) {
       enqueueClass(enqueuer, cls, registry);
     }
     for (BackendImpact otherImpact in impact.otherImpacts) {
       enqueueImpact(enqueuer, otherImpact, registry);
     }
   }
 
   WorldImpact codegen(CodegenWorkItem work) {
     Element element = work.element;
-    if (compiler.elementHasCompileTimeError(element)) {
+    if (compiler.generateCodeWithCompileTimeErrors &&
+        compiler.elementHasCompileTimeError(element)) {
       generatedCode[element] = jsAst.js(
           "function () { throw new Error('Compile time error in $element') }");

[Johnni Winther, 2015/12/14 11:31:20]

We could use the message here as well.

[sigurdm, 2015/12/14 12:07:43]

Done.

       return const CodegenImpact();
     }
     var kind = element.kind;
     if (kind == ElementKind.TYPEDEF) {
       return const WorldImpact();
     }
     if (element.isConstructor &&
         element.enclosingClass == helpers.jsNullClass) {
       // Work around a problem compiling JSNull's constructor.
       return const CodegenImpact();
@@ skipping 1493 matching lines @@
   }
 }
 
 /// Records that [constant] is used by the element behind [registry].
 class Dependency {
   final ConstantValue constant;
   final Element annotatedElement;
 
   const Dependency(this.constant, this.annotatedElement);
 }