Associate compile-time errors with elements

pkg/compiler/lib/src/resolution/class_hierarchy.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.resolution.class_hierarchy;
 
 import '../common.dart';
 import '../common/resolution.dart' show
     Feature;
 import '../compiler.dart' show
@@ skipping 201 matching lines @@
           reporter.reportErrorMessage(node, kind, arguments);
           superMember = new ErroneousElementX(
               kind, arguments, '', element);
           registry.registerFeature(Feature.THROW_NO_SUCH_METHOD);
       } else {
         ConstructorElement superConstructor = superMember;
         superConstructor.computeType(resolution);
         if (!CallStructure.NO_ARGS.signatureApplies(
                 superConstructor.functionSignature)) {
           MessageKind kind = MessageKind.NO_MATCHING_CONSTRUCTOR_FOR_IMPLICIT;
-          reporter.reportErrorMessage(node, kind);
+          DiagnosticMessage message = reporter.createMessage(node, kind);
+          reporter.reportError(message);

[Johnni Winther, 2015/12/14 11:31:20]

This change doesn't seem to be needed.

[sigurdm, 2015/12/14 12:07:43]

Done.

           superMember = new ErroneousElementX(kind, {}, '', element);
         }
       }
       FunctionElement constructor =
           new SynthesizedConstructorElementX.forDefault(superMember, element);
       if (superMember.isMalformed) {
-        compiler.elementsWithCompileTimeErrors.add(constructor);
+        ErroneousElement erroneousElement = superMember;
+        compiler.elementsWithCompileTimeErrors[constructor] =
+            reporter.createMessage(node,
+                erroneousElement.messageKind,
+                erroneousElement.messageArguments);
       }
       element.setDefaultConstructor(constructor, reporter);
     }
     return element.computeType(resolution);
   }
 
   @override
   DartType visitEnum(Enum node) {
     if (element == null) {
       throw reporter.internalError(node, 'element is null');
@@ skipping 478 matching lines @@
     if (e == null || !e.impliesType) {
       reporter.reportErrorMessage(
           node.selector,
           MessageKind.CANNOT_RESOLVE_TYPE,
           {'typeName': node.selector});
       return;
     }
     loadSupertype(e, node);
   }
 }