Issue 1525303003: Remove QuicPacketGenerator::OnSerializedPacket with functionality in QuicPacketCreator. No functio…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1525303003: Remove QuicPacketGenerator::OnSerializedPacket with functionality in QuicPacketCreator. No functio… (Closed)

Created:
5 years ago by danzh1

Modified:
5 years ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@110008813

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove QuicPacketGenerator::OnSerializedPacket with functionality in QuicPacketCreator. No functional change. Merge internal change: 110015448 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : get newly added files from upstream #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+82 lines, -73 lines)			Patch
M	net/quic/quic_connection.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	net/quic/quic_connection.cc	View	1 chunk	+4 lines, -5 lines	0 comments	Download
M	net/quic/quic_connection_test.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	net/quic/quic_packet_creator.h	View	4 chunks	+17 lines, -1 line	0 comments	Download
M	net/quic/quic_packet_creator.cc	View	5 chunks	+31 lines, -7 lines	0 comments	Download
M	net/quic/quic_packet_creator_test.cc	View	2 chunks	+12 lines, -2 lines	0 comments	Download
M	net/quic/quic_packet_generator.h	View	4 chunks	+5 lines, -17 lines	0 comments	Download
M	net/quic/quic_packet_generator.cc	View	4 chunks	+3 lines, -34 lines	0 comments	Download
M	net/quic/quic_packet_generator_test.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Depends on Patchset:

Issue 1521993006 Patch 40001

Dependent Patchsets:

Issue 1529953003 Patch 20001

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages