Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1529953003: Make QuicSpdyStream::WriteTrailers virtual for tests. No behavior change. (Closed)

Created:
5 years ago by danzh1
Modified:
5 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@110015448
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make QuicSpdyStream::WriteTrailers virtual for tests. No behavior change. Merge internal change: 110021608 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : get newly added files from upstream #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/quic/quic_spdy_stream.h View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1525303003 Patch 20001

Dependent Patchsets:

Issue 1531543004 Patch 1

Messages

Total messages: 5 (1 generated)
danzh1
5 years ago (2015-12-15 20:31:32 UTC) #1
Ryan Hamilton
Please modify the CL description to reflect the actual merged change. In this case, it ...
5 years ago (2015-12-15 21:21:07 UTC) #2
danzh1
On 2015/12/15 21:21:07, Ryan Hamilton wrote: > Please modify the CL description to reflect the ...
5 years ago (2015-12-15 21:32:31 UTC) #4
Ryan Hamilton
5 years ago (2015-12-15 22:52:34 UTC) #5 
On 2015/12/15 21:32:31, danzh1 wrote:
> On 2015/12/15 21:21:07, Ryan Hamilton wrote:
> > Please modify the CL description to reflect the actual merged change. In
this
> > case, it seems to just make a method virtual.
> 
> done.

(I also updated the CL subject. Didn't realize a reviewer could do that. Cool!
:>)

LGTM

Powered by Google App Engine
This is Rietveld 408576698