Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1609)

Unified Diff: net/quic/quic_packet_generator_test.cc

Issue 1525303003: Remove QuicPacketGenerator::OnSerializedPacket with functionality in QuicPacketCreator. No functio… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@110008813
Patch Set: get newly added files from upstream Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_packet_generator.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_packet_generator_test.cc
diff --git a/net/quic/quic_packet_generator_test.cc b/net/quic/quic_packet_generator_test.cc
index 7b3ee589b12a7f47e5c2badd122f1c93c8f4c697..f61cae80b93c53b052aea42ce0ed12005148c3aa 100644
--- a/net/quic/quic_packet_generator_test.cc
+++ b/net/quic/quic_packet_generator_test.cc
@@ -49,7 +49,7 @@ class MockDelegate : public QuicPacketGenerator::DelegateInterface {
IsHandshake handshake));
MOCK_METHOD1(PopulateAckFrame, void(QuicAckFrame*));
MOCK_METHOD1(PopulateStopWaitingFrame, void(QuicStopWaitingFrame*));
- MOCK_METHOD1(OnSerializedPacket, void(const SerializedPacket& packet));
+ MOCK_METHOD1(OnSerializedPacket, void(SerializedPacket* packet));
MOCK_METHOD2(CloseConnection, void(QuicErrorCode, bool));
MOCK_METHOD0(OnResetFecGroup, void());
@@ -125,9 +125,9 @@ class QuicPacketGeneratorTest : public ::testing::TestWithParam<FecSendPolicy> {
}
}
- void SavePacket(const SerializedPacket& packet) {
- packets_.push_back(packet);
- ASSERT_FALSE(packet.packet->owns_buffer());
+ void SavePacket(SerializedPacket* packet) {
+ packets_.push_back(*packet);
+ ASSERT_FALSE(packet->packet->owns_buffer());
scoped_ptr<QuicEncryptedPacket> encrypted_deleter(packets_.back().packet);
packets_.back().packet = packets_.back().packet->Clone();
}
« no previous file with comments | « net/quic/quic_packet_generator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698