Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1525033004: Always set the error handler closure of Binding<> after binding to a message pipe. (Closed)

Created:
5 years ago by Anand Mistry (off Chromium)
Modified:
5 years ago
Reviewers:
jam
CC:
chromium-reviews, cbentzel+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always set the error handler closure of Binding<> after binding to a message pipe. This change only modifies users of Binding<>, and not the bindings code itself. The intention is to bring the behaviour of Binding<> closer to that of InterfacePtr<>, which already has this restriction. BUG=569694 Committed: https://crrev.com/d8ee03d1531318ede1c06ce7b2d3bff129eb8863 Cr-Commit-Position: refs/heads/master@{#365710}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17 lines) Patch
M content/common/mojo/service_registry_impl.cc View 1 2 chunks +3 lines, -5 lines 0 comments Download
M mojo/runner/child/runner_connection.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M mojo/runner/host/child_process.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M mojo/shell/application_instance.cc View 2 chunks +1 line, -1 line 0 comments Download
M net/proxy/proxy_resolver_factory_mojo.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (8 generated)
Anand Mistry (off Chromium)
Change is trivial, to several different directories. Figured I'd just get one stamp instead of ...
5 years ago (2015-12-16 00:42:13 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525033004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525033004/1
5 years ago (2015-12-16 00:45:07 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
5 years ago (2015-12-16 02:53:01 UTC) #6
jam
lgtm
5 years ago (2015-12-16 18:38:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525033004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525033004/1
5 years ago (2015-12-16 22:18:47 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/243) android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, ...
5 years ago (2015-12-16 22:26:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525033004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525033004/20001
5 years ago (2015-12-16 22:44:56 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-17 03:23:25 UTC) #15
commit-bot: I haz the power
5 years ago (2015-12-17 03:24:18 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d8ee03d1531318ede1c06ce7b2d3bff129eb8863
Cr-Commit-Position: refs/heads/master@{#365710}

Powered by Google App Engine
This is Rietveld 408576698