Modify bindings to enforce that an error handler callback is only set after binding to a msg pipe.

Modify Binding<>, StrongBinding<>, and AssociatedBinding<> to enforce that an error handler callback is only set after binding to a message pipe.

Also, reset the callback when the binding unbound from the message pipe.
This replicates the behaviour of InterfacePtr<>.

BUG=569694
Committed: https://crrev.com/f7038757b49a6d7498be0b0a2efee3bb82918a4a
Cr-Commit-Position: refs/heads/master@{#365749}

[Anand Mistry (off Chromium), 2015-12-16 00:51:34]

The CQ bit was checked by amistry@chromium.org to run a CQ dry run

[Anand Mistry (off Chromium), 2015-12-16 00:51:48]

amistry@chromium.org changed reviewers:
+ yzshen@chromium.org

[commit-bot: I haz the power, 2015-12-16 00:52:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1531543003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1531543003/1

[yzshen1, 2015-12-16 00:56:06]

Please also make similar changes to AssociatedBinding

https://codereview.chromium.org/1531543003/diff/1/mojo/public/cpp/bindings/li...
File mojo/public/cpp/bindings/lib/binding_state.h (right):

https://codereview.chromium.org/1531543003/diff/1/mojo/public/cpp/bindings/li...
mojo/public/cpp/bindings/lib/binding_state.h:179: router_ = nullptr;
Please also make the corresponding changes here.

https://codereview.chromium.org/1531543003/diff/1/mojo/public/cpp/bindings/li...
mojo/public/cpp/bindings/lib/binding_state.h:182: InterfaceRequest<Interface>
Unbind() {
ditto.

[Anand Mistry (off Chromium), 2015-12-16 01:49:24]

Description was changed from

==========
Modify Binding<> and StrongBinding<> to enforce that an error handler callback
is only set after binding to a message pipe.

Also, reset the callback when the binding unbound from the message pipe.
This replicates the behaviour of InterfacePtr<>.

BUG=569694
==========

to

==========
Modify Binding<>, StrongBinding<>, and AssociatedBinding<> to enforce that an
error handler callback is only set after binding to a message pipe.

Also, reset the callback when the binding unbound from the message pipe.
This replicates the behaviour of InterfacePtr<>.

BUG=569694
==========

[Anand Mistry (off Chromium), 2015-12-16 01:49:34]

https://codereview.chromium.org/1531543003/diff/1/mojo/public/cpp/bindings/li...
File mojo/public/cpp/bindings/lib/binding_state.h (right):

https://codereview.chromium.org/1531543003/diff/1/mojo/public/cpp/bindings/li...
mojo/public/cpp/bindings/lib/binding_state.h:179: router_ = nullptr;
On 2015/12/16 00:56:06, yzshen1 wrote:
> Please also make the corresponding changes here.

Done.

https://codereview.chromium.org/1531543003/diff/1/mojo/public/cpp/bindings/li...
mojo/public/cpp/bindings/lib/binding_state.h:182: InterfaceRequest<Interface>
Unbind() {
On 2015/12/16 00:56:05, yzshen1 wrote:
> ditto.

Done.

[yzshen1, 2015-12-17 00:59:06]

LGTM

Please also add a comment in InterfacePtr<> and Binding<>'s header files about
threading.

[Anand Mistry (off Chromium), 2015-12-17 02:30:56]

On 2015/12/17 00:59:06, yzshen1 (OOO till new year) wrote:
> LGTM
> 
> Please also add a comment in InterfacePtr<> and Binding<>'s header files about
> threading.

I'll add a comment about what happens to the error handler, but this change
doesn't yet change the threading semantics. Once I've made the necessary changes
and verified it has the behaviour we want, then I will.

[Anand Mistry (off Chromium), 2015-12-17 03:33:44]

The CQ bit was checked by amistry@chromium.org

[Anand Mistry (off Chromium), 2015-12-17 03:33:45]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/1531543003/#ps40001
(title: "Add error handler comment.")

[commit-bot: I haz the power, 2015-12-17 03:37:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1531543003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1531543003/40001

[commit-bot: I haz the power, 2015-12-17 05:23:50]

Description was changed from

==========
Modify Binding<>, StrongBinding<>, and AssociatedBinding<> to enforce that an
error handler callback is only set after binding to a message pipe.

Also, reset the callback when the binding unbound from the message pipe.
This replicates the behaviour of InterfacePtr<>.

BUG=569694
==========

to

==========
Modify Binding<>, StrongBinding<>, and AssociatedBinding<> to enforce that an
error handler callback is only set after binding to a message pipe.

Also, reset the callback when the binding unbound from the message pipe.
This replicates the behaviour of InterfacePtr<>.

BUG=569694
==========

[commit-bot: I haz the power, 2015-12-17 05:23:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-17 05:25:34]

Description was changed from

==========
Modify Binding<>, StrongBinding<>, and AssociatedBinding<> to enforce that an
error handler callback is only set after binding to a message pipe.

Also, reset the callback when the binding unbound from the message pipe.
This replicates the behaviour of InterfacePtr<>.

BUG=569694
==========

to

==========
Modify Binding<>, StrongBinding<>, and AssociatedBinding<> to enforce that an
error handler callback is only set after binding to a message pipe.

Also, reset the callback when the binding unbound from the message pipe.
This replicates the behaviour of InterfacePtr<>.

BUG=569694

Committed: https://crrev.com/f7038757b49a6d7498be0b0a2efee3bb82918a4a
Cr-Commit-Position: refs/heads/master@{#365749}
==========

[commit-bot: I haz the power, 2015-12-17 05:25:34]

Patchset 3 (id:??) landed as
https://crrev.com/f7038757b49a6d7498be0b0a2efee3bb82918a4a
Cr-Commit-Position: refs/heads/master@{#365749}