Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: mojo/shell/application_instance.cc

Issue 1525033004: Always set the error handler closure of Binding<> after binding to a message pipe. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/runner/host/child_process.cc ('k') | net/proxy/proxy_resolver_factory_mojo.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/application_instance.cc
diff --git a/mojo/shell/application_instance.cc b/mojo/shell/application_instance.cc
index 8bd81387c75c8f637b70000f3d43c764af1814d8..63851afac675ae43ab880871821b6ce7c801e744 100644
--- a/mojo/shell/application_instance.cc
+++ b/mojo/shell/application_instance.cc
@@ -31,7 +31,6 @@ ApplicationInstance::ApplicationInstance(
queue_requests_(false),
native_runner_(nullptr),
pid_(base::kNullProcessId) {
- binding_.set_connection_error_handler([this]() { OnConnectionError(); });
}
ApplicationInstance::~ApplicationInstance() {
@@ -43,6 +42,7 @@ ApplicationInstance::~ApplicationInstance() {
void ApplicationInstance::InitializeApplication() {
ShellPtr shell;
binding_.Bind(GetProxy(&shell));
+ binding_.set_connection_error_handler([this]() { OnConnectionError(); });
application_->Initialize(shell.Pass(), identity_.url().spec());
}
« no previous file with comments | « mojo/runner/host/child_process.cc ('k') | net/proxy/proxy_resolver_factory_mojo.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698