Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Issue 1523883002: EDK: Add a PlatformHandleWatcher argument to embedder::InitIPCSupport(). (Closed)

Created:
5 years ago by viettrungluu
Modified:
5 years ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Add a PlatformHandleWatcher argument to embedder::InitIPCSupport(). RawChannel should get the task runner and platform handle watcher explicitly injected. Which means Channel should too. Which means that IPCSupport should too. Which means that this function should take a platform handle watcher. (I tried converting RawChannel first, but then I would have had to do everything at once.) R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/c678d0f3c96b32d3c4488d8105cf9c3bcad41978

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -59 lines) Patch
M mojo/edk/embedder/embedder.h View 3 chunks +10 lines, -5 lines 0 comments Download
M mojo/edk/embedder/embedder.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M mojo/edk/embedder/embedder_unittest.cc View 9 chunks +19 lines, -7 lines 0 comments Download
M mojo/edk/test/scoped_ipc_support.h View 5 chunks +24 lines, -17 lines 0 comments Download
M mojo/edk/test/scoped_ipc_support.cc View 6 chunks +29 lines, -21 lines 0 comments Download
M shell/child_main.cc View 8 chunks +18 lines, -7 lines 0 comments Download
M shell/context.cc View 1 chunk +1 line, -0 lines 0 comments Download
M shell/task_runners.h View 3 chunks +8 lines, -0 lines 0 comments Download
M shell/task_runners.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 4 (1 generated)
viettrungluu
5 years ago (2015-12-14 21:41:33 UTC) #1
vardhan
lgtm
5 years ago (2015-12-15 02:03:53 UTC) #2
viettrungluu
5 years ago (2015-12-15 17:45:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c678d0f3c96b32d3c4488d8105cf9c3bcad41978 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698