Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1221)

Unified Diff: mojo/edk/test/scoped_ipc_support.cc

Issue 1523883002: EDK: Add a PlatformHandleWatcher argument to embedder::InitIPCSupport(). (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/test/scoped_ipc_support.h ('k') | shell/child_main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/test/scoped_ipc_support.cc
diff --git a/mojo/edk/test/scoped_ipc_support.cc b/mojo/edk/test/scoped_ipc_support.cc
index 4d96d152968c82d409577f0368d5ba9d58b2ae7a..314ad0e742bd2b959b26189b7d604e39c1e0ac8d 100644
--- a/mojo/edk/test/scoped_ipc_support.cc
+++ b/mojo/edk/test/scoped_ipc_support.cc
@@ -8,6 +8,7 @@
#include "mojo/edk/embedder/embedder.h"
+using mojo::platform::PlatformHandleWatcher;
using mojo::platform::ScopedPlatformHandle;
using mojo::platform::TaskRunner;
using mojo::util::RefPtr;
@@ -20,7 +21,7 @@ namespace internal {
ScopedIPCSupportHelper::ScopedIPCSupportHelper() {}
ScopedIPCSupportHelper::~ScopedIPCSupportHelper() {
- if (io_thread_task_runner_->RunsTasksOnCurrentThread()) {
+ if (io_task_runner_->RunsTasksOnCurrentThread()) {
embedder::ShutdownIPCSupportOnIOThread();
} else {
embedder::ShutdownIPCSupport();
@@ -30,13 +31,15 @@ ScopedIPCSupportHelper::~ScopedIPCSupportHelper() {
void ScopedIPCSupportHelper::Init(embedder::ProcessType process_type,
embedder::ProcessDelegate* process_delegate,
- RefPtr<TaskRunner>&& io_thread_task_runner,
+ RefPtr<TaskRunner>&& io_task_runner,
+ PlatformHandleWatcher* io_watcher,
ScopedPlatformHandle platform_handle) {
- io_thread_task_runner_ = std::move(io_thread_task_runner);
+ io_task_runner_ = std::move(io_task_runner);
+ io_watcher_ = io_watcher;
// Note: Run delegate methods on the I/O thread.
- embedder::InitIPCSupport(process_type, io_thread_task_runner_.Clone(),
- process_delegate, io_thread_task_runner_.Clone(),
- platform_handle.Pass());
+ embedder::InitIPCSupport(process_type, io_task_runner_.Clone(),
+ process_delegate, io_task_runner_.Clone(),
+ io_watcher_, platform_handle.Pass());
}
void ScopedIPCSupportHelper::OnShutdownCompleteImpl() {
@@ -45,9 +48,10 @@ void ScopedIPCSupportHelper::OnShutdownCompleteImpl() {
} // namespace internal
-ScopedIPCSupport::ScopedIPCSupport(RefPtr<TaskRunner>&& io_thread_task_runner) {
- helper_.Init(embedder::ProcessType::NONE, this,
- std::move(io_thread_task_runner), ScopedPlatformHandle());
+ScopedIPCSupport::ScopedIPCSupport(RefPtr<TaskRunner>&& io_task_runner,
+ PlatformHandleWatcher* io_watcher) {
+ helper_.Init(embedder::ProcessType::NONE, this, std::move(io_task_runner),
+ io_watcher, ScopedPlatformHandle());
}
ScopedIPCSupport::~ScopedIPCSupport() {
@@ -58,17 +62,19 @@ void ScopedIPCSupport::OnShutdownComplete() {
}
ScopedMasterIPCSupport::ScopedMasterIPCSupport(
- RefPtr<TaskRunner>&& io_thread_task_runner) {
- helper_.Init(embedder::ProcessType::MASTER, this,
- std::move(io_thread_task_runner), ScopedPlatformHandle());
+ RefPtr<TaskRunner>&& io_task_runner,
+ PlatformHandleWatcher* io_watcher) {
+ helper_.Init(embedder::ProcessType::MASTER, this, std::move(io_task_runner),
+ io_watcher, ScopedPlatformHandle());
}
ScopedMasterIPCSupport::ScopedMasterIPCSupport(
- RefPtr<TaskRunner>&& io_thread_task_runner,
+ RefPtr<TaskRunner>&& io_task_runner,
+ PlatformHandleWatcher* io_watcher,
std::function<void(embedder::SlaveInfo slave_info)>&& on_slave_disconnect)
: on_slave_disconnect_(std::move(on_slave_disconnect)) {
- helper_.Init(embedder::ProcessType::MASTER, this,
- std::move(io_thread_task_runner), ScopedPlatformHandle());
+ helper_.Init(embedder::ProcessType::MASTER, this, std::move(io_task_runner),
+ io_watcher, ScopedPlatformHandle());
}
ScopedMasterIPCSupport::~ScopedMasterIPCSupport() {
@@ -84,19 +90,21 @@ void ScopedMasterIPCSupport::OnSlaveDisconnect(embedder::SlaveInfo slave_info) {
}
ScopedSlaveIPCSupport::ScopedSlaveIPCSupport(
- RefPtr<TaskRunner>&& io_thread_task_runner,
+ RefPtr<TaskRunner>&& io_task_runner,
+ PlatformHandleWatcher* io_watcher,
ScopedPlatformHandle platform_handle) {
- helper_.Init(embedder::ProcessType::SLAVE, this,
- std::move(io_thread_task_runner), platform_handle.Pass());
+ helper_.Init(embedder::ProcessType::SLAVE, this, std::move(io_task_runner),
+ io_watcher, platform_handle.Pass());
}
ScopedSlaveIPCSupport::ScopedSlaveIPCSupport(
- RefPtr<TaskRunner>&& io_thread_task_runner,
+ RefPtr<TaskRunner>&& io_task_runner,
+ PlatformHandleWatcher* io_watcher,
ScopedPlatformHandle platform_handle,
std::function<void()>&& on_master_disconnect)
: on_master_disconnect_(std::move(on_master_disconnect)) {
- helper_.Init(embedder::ProcessType::SLAVE, this,
- std::move(io_thread_task_runner), platform_handle.Pass());
+ helper_.Init(embedder::ProcessType::SLAVE, this, std::move(io_task_runner),
+ io_watcher, platform_handle.Pass());
}
ScopedSlaveIPCSupport::~ScopedSlaveIPCSupport() {
« no previous file with comments | « mojo/edk/test/scoped_ipc_support.h ('k') | shell/child_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698