Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1525883002: EDK: Add PlatformHandleWatcher to IPCSupport class. (Closed)

Created:
5 years ago by viettrungluu
Modified:
5 years ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@embedder_watcher
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Add PlatformHandleWatcher to IPCSupport class. Step 2 in plumbing it down to the RawChannel. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/88d61fcfc407d2b7d271630cf422ca0c2cd081d3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -16 lines) Patch
M mojo/edk/embedder/embedder.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/edk/system/ipc_support.h View 4 chunks +10 lines, -4 lines 0 comments Download
M mojo/edk/system/ipc_support.cc View 4 chunks +11 lines, -7 lines 0 comments Download
M mojo/edk/system/ipc_support_unittest.cc View 4 chunks +7 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 4 (1 generated)
viettrungluu
(Dependent on https://codereview.chromium.org/1523883002/ .)
5 years ago (2015-12-15 00:23:59 UTC) #1
vardhan
lgtm (mojo:network_service_apptests is failing -- is it just flakey? this doesn't look related)
5 years ago (2015-12-15 02:06:35 UTC) #2
viettrungluu
5 years ago (2015-12-15 17:46:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
88d61fcfc407d2b7d271630cf422ca0c2cd081d3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698