Issue 1525883002: EDK: Add PlatformHandleWatcher to IPCSupport class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1525883002: EDK: Add PlatformHandleWatcher to IPCSupport class. (Closed)

Created:
5 years ago by viettrungluu

Modified:
5 years ago

Reviewers:
vardhan

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@embedder_watcher

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

EDK: Add PlatformHandleWatcher to IPCSupport class. Step 2 in plumbing it down to the RawChannel. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/88d61fcfc407d2b7d271630cf422ca0c2cd081d3

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -16 lines)			Patch
M	mojo/edk/embedder/embedder.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	mojo/edk/system/ipc_support.h	View	4 chunks	+10 lines, -4 lines	0 comments	Download
M	mojo/edk/system/ipc_support.cc	View	4 chunks	+11 lines, -7 lines	0 comments	Download
M	mojo/edk/system/ipc_support_unittest.cc	View	4 chunks	+7 lines, -2 lines	0 comments	Download

Depends on Patchset:

Issue 1523883002 Patch 1

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

vardhan

lgtm (mojo:network_service_apptests is failing -- is it just flakey? this doesn't look related)

5 years ago (2015-12-15 02:06:35 UTC) #2

viettrungluu

5 years ago (2015-12-15 17:46:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
88d61fcfc407d2b7d271630cf422ca0c2cd081d3 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages