DescriptionReland of Update media notification when page title changes (patchset #1 id:1 of https://codereview.chromium.org/1528563003/ )
Reason for revert:
revert broke the build, which seems worse than breaking the tests.
Original issue's description:
> Revert of Update media notification when page title changes (patchset #26 id:590001 of https://codereview.chromium.org/1417743005/ )
>
> Reason for revert:
> It looks to me like this change is causing failures in the ChromeSyncShellTest, e.g.:
> https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/31876
> https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/31877
>
> Not sure why this builds successfully, but the signature change to ChromeActivityTestCaseBase.loadUrlInNewTab causes OpenTabsTest to fail at runtime.
>
> C 97.565s Main [FAIL] org.chromium.chrome.browser.sync.OpenTabsTest#testUploadAndCloseOpenTab:
> C 97.565s Main java.lang.NoSuchMethodError: org.chromium.chrome.browser.sync.OpenTabsTest.loadUrlInNewTab
> C 97.565s Main at org.chromium.chrome.browser.sync.OpenTabsTest.testUploadAndCloseOpenTab(OpenTabsTest.java:108)
> C 97.566s Main at java.lang.reflect.Method.invokeNative(Native Method)
> C 97.566s Main at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
> C 97.566s Main at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
>
> Original issue's description:
> > Update media notification when page title changes
> >
> > This CL makes the media notification keep in sync when the page title
> > changes.
> >
> > BUG=550424
> >
> > Committed: https://crrev.com/d0b0d5fe705a29ff989dd3708d61154e8c600024
> > Cr-Commit-Position: refs/heads/master@{#364938}
> >
> > Committed: https://crrev.com/bb18959a99173041dd3f7bbf99b437749b9b79f6
> > Cr-Commit-Position: refs/heads/master@{#365047}
>
> TBR=mlamouri@chromium.org,avayvod@chromium.org,tedchoc@chromium.org,zqzhang@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=550424
>
> Committed: https://crrev.com/022ddd8bed4270541d3858edf36d184b86b447bc
> Cr-Commit-Position: refs/heads/master@{#365135}
TBR=mlamouri@chromium.org,avayvod@chromium.org,tedchoc@chromium.org,zqzhang@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=550424
Committed: https://crrev.com/6000fdb186d7b9c803eedf618a609ba2bf2136ba
Cr-Commit-Position: refs/heads/master@{#365137}
Patch Set 1 #Messages
Total messages: 5 (1 generated)
|