content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java - Issue 1523173003: Reland of Update media notification when page title changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

Issue 1523173003: Reland of Update media notification when page title changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java ('k') | content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

index e2d6cef60d46d20775c46ca4ef15664df9571339..04c3745c6e3400957827683dad656bdd588c78b5 100644

--- a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

+++ b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

@@ -12,6 +12,7 @@

import android.os.ParcelUuid;

import android.os.Parcelable;

+import org.chromium.base.ObserverList;

import org.chromium.base.VisibleForTesting;

import org.chromium.base.annotations.CalledByNative;

import org.chromium.base.annotations.JNINamespace;

@@ -423,6 +424,12 @@

public void removeObserver(WebContentsObserver observer) {

if (mObserverProxy == null) return;

mObserverProxy.removeObserver(observer);

+ }

+ @VisibleForTesting

+ @Override

+ public ObserverList.RewindableIterator<WebContentsObserver> getObserversForTesting() {

+ return mObserverProxy.getObserversForTesting();

}

@Override