chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java - Issue 1523173003: Reland of Update media notification when page title changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java

Issue 1523173003: Reland of Update media notification when page title changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java

index 4dce275145e12262ab48b4e9f507118a269db701..b0f07d43932958bf58af5c1dabc054a614e5cfdb 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java

@@ -139,6 +139,16 @@

public void onContentChanged(Tab tab) {

assert tab == mTab;

setWebContents(tab.getWebContents());

+ }

+ @Override

+ public void onTitleUpdated(Tab tab) {

+ assert tab == mTab;

+ if (mNotificationInfoBuilder == null) return;

+ mNotificationInfoBuilder.setTitle(sanitizeMediaTitle(mTab.getTitle()));

+ MediaNotificationManager.show(ApplicationStatus.getApplicationContext(),

+ mNotificationInfoBuilder.build());

}

@Override