Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1522583003: New Mojom compiler: Assign a meaningful spec string instead of 'dummyspec' because it turns out it… (Closed)

Created:
5 years ago by rudominer
Modified:
5 years ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

New Mojom compiler: Assign a meaningful spec string instead of 'dummyspec' because it turns out it is used in error messages. BUG=#461 R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1a59579db9eb403debdd198d01cde6835d0aacd1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator.py View 3 chunks +10 lines, -4 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator_unittest.py View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rudominer
Hi Alex, ptal.
5 years ago (2015-12-11 22:18:20 UTC) #3
azani
lgtm
5 years ago (2015-12-11 22:25:36 UTC) #4
rudominer
5 years ago (2015-12-11 22:26:35 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
1a59579db9eb403debdd198d01cde6835d0aacd1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698