New Mojom compiler: Assign a meaningful spec string instead of 'dummyspec' because it turns out it…

mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator.py

 #!/usr/bin/env python
 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 #
 # This module is responsible for translating a MojomFileGraph (see
 # mojom_files.mojom) to one or more module.Module.
 #
 # This module takes the output of the mojom parser, a MojomFileGraph  and
 # translates it to the input of the code generators, a module.Module object.
@@ skipping 315 matching lines @@
 
   def PopulateUserDefinedType(self, module_type, mojom):
     """Populates fields that are common among user-defined types.
 
     Args:
       module_type: {module.Struct|Union|Enum} to be populated.
       mojom: {MojomStruct|MojomUnion|MojomEnum} to be translated.
     """
     module_type.attributes = self.AttributesFromMojom(mojom)
     module_type.name = mojom.decl_data.short_name
+    module_type.spec = mojom.decl_data.full_identifier
+    if module_type.spec == None:
+      module_type.spec = mojom.decl_data.short_name
     self.PopulateModuleOrImportedFrom(module_type, mojom)
 
   def PopulateModuleOrImportedFrom(self, module_type, mojom):
     """Populates either the module field or the imported_from field.
 
     All user-defined types must have either the module field populated (if
     they are from the currently-processed module) or the imported_from (if
     they are imported from another module).
 
     Args:
@@ skipping 34 matching lines @@
     """
     assert (mojom_type.tag
         == mojom_types_mojom.UserDefinedType.Tags.interface_type)
     mojom_interface = mojom_type.interface_type
     interface.attributes = self.AttributesFromMojom(mojom_interface)
     interface.service_name = None
     if interface.attributes:
       interface.service_name = interface.attributes.get('ServiceName')
     self.PopulateModuleOrImportedFrom(interface, mojom_interface)
     interface.name = mojom_interface.interface_name
+    interface.spec = interface.name
+
     interface.methods = [self.MethodFromMojom(mojom_method, interface)
         for mojom_method in mojom_interface.methods.itervalues()]
     self.PopulateContainedDeclarationsFromMojom(
         interface, mojom_interface.decl_data.contained_declarations)
 
   def MethodFromMojom(self, mojom_method, interface):
     """Translates a mojom_types_mojom.MojomMethod to a module.Method.
 
     Args:
       mojom_method: {mojom_types_mojom.MojomMethod} to be translated.
@@ skipping 352 matching lines @@
         mojom_types_mojom.UserDefinedType.Tags.enum_type:
         (module.Enum, self.EnumFromMojom),
         mojom_types_mojom.UserDefinedType.Tags.union_type:
         (module.Union, self.UnionFromMojom),
         mojom_types_mojom.UserDefinedType.Tags.interface_type:
         (module.Interface, self.InterfaceFromMojom),
         }
     module_type_class, from_mojom = user_defined_types[mojom_type.tag]
     module_type = module_type_class()
 
-    # module.py expects the spec of user defined types to be set when
-    # constructing map, array, and interface request types, but the value
-    # appears unimportant.
-    module_type.spec = 'dummyspec'
+    if module_type.spec == None:
+      # module.py expects the spec of user defined types to be set when
+      # constructing map, array, and interface request types, but the value
+      # appears to be only used for error messages.
+      module_type.spec = 'dummyspec'
 
     # It is necessary to cache the type object before populating it since in
     # the course of populating it, it may be necessary to resolve that same
     # type (say, a struct with a field of its own type).
     self._type_cache[type_key] = module_type
     from_mojom(module_type, mojom_type)
 
     return module_type
 
 
 def TranslateFileGraph(graph):
   """Translates a mojom_types_mojom.MojomFileGraph to module.Module(s).
 
   The input is the output of the parser. The output is the input to the
   various bindings generators.
 
   Args:
     graph: {mojom_types_mojom.MojomFileGraph} to be translated.
 
   Return:
     {dict<str, module.Module>} mapping the file's name to its module.Module
     translation for all files in graph.files.
   """
   return {file_name: FileTranslator(graph, file_name).Translate()
       for file_name in graph.files}