New Mojom compiler: Assign a meaningful spec string instead of 'dummyspec' because it turns out it…

mojo/public/tools/bindings/pylib/mojom/generate/mojom_translator_unittest.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import unittest
 import module
 
 try:
   import mojom_translator
   from generated import mojom_files_mojom
@@ skipping 59 matching lines @@
           source_file_info=mojom_types_mojom.SourceFileInfo(
             file_name=file_name)),
         interface_name='AnInterface')
     graph.resolved_types['interface_key'] = mojom_types_mojom.UserDefinedType(
         interface_type=mojom_interface)
 
     mojom_struct = mojom_types_mojom.MojomStruct(
         fields=[],
         decl_data=mojom_types_mojom.DeclarationData(
           short_name='AStruct',
+          full_identifier='foo.AStruct',
           source_file_info=mojom_types_mojom.SourceFileInfo(
             file_name=file_name)))
     graph.resolved_types['struct_key'] = mojom_types_mojom.UserDefinedType(
         struct_type=mojom_struct)
 
     mojom_union = mojom_types_mojom.MojomUnion(
         fields=[],
         decl_data=mojom_types_mojom.DeclarationData(
           short_name='AUnion',
           source_file_info=mojom_types_mojom.SourceFileInfo(
@@ skipping 41 matching lines @@
         mod.imports[0]['namespace'])
     self.assertEquals(imported_file.file_name, mod.imports[0]['module'].path)
 
     self.assertEquals(2, len(mod.transitive_imports))
     transitive_imports_paths = [imp['module'].path
         for imp in mod.transitive_imports]
     self.assertIn(imported_file_name, transitive_imports_paths)
     self.assertIn(second_level_imported_file_name, transitive_imports_paths)
 
     self.assertEquals(mojom_interface.interface_name, mod.interfaces[0].name)
+    # Interfaces should be assigned their name as their spec.
+    self.assertEquals('AnInterface', mod.interfaces[0].spec)
     self.assertEquals(mojom_struct.decl_data.short_name, mod.structs[0].name)
+    # The struct was given a full_identifier so its spec should be that.
+    self.assertEquals(mojom_struct.decl_data.full_identifier,
+        mod.structs[0].spec)
     self.assertEquals(mojom_union.decl_data.short_name, mod.unions[0].name)
+    # The union was given a short name but not a full_identifier so its spec
+    # should be the short name.
+    self.assertEquals(mojom_union.decl_data.short_name,
+        mod.unions[0].spec)
     self.assertEquals(mojom_enum.decl_data.short_name, mod.enums[0].name)
     self.assertEquals(mojom_const.decl_data.short_name, mod.constants[0].name)
 
   def test_no_imports(self):
     graph = mojom_files_mojom.MojomFileGraph(
         resolved_types={})
     file_name = 'root/f.mojom'
     mojom_file = mojom_files_mojom.MojomFile(
         file_name=file_name,
         module_namespace='somens')
@@ skipping 737 matching lines @@
     result2 = t.KindFromMojom(mojom_type)
     self.assertIs(result, result2)
 
     # Nullable type reference
     mojom_type.type_reference.nullable = True
     nullable_result = t.KindFromMojom(mojom_type)
     self.assertTrue(module.IsNullableKind(nullable_result))
 
 if __name__ == '__main__':
   unittest.main()