Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1521613002: Make draw* lines responsible for cache management (Closed)

Created:
5 years ago by joshua.litt
Modified:
5 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@cleanuptext13reallytexutilsdf
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make draw* lines responsible for cache management TBR=bsalomon@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/66957946c0c418e71c0f36bb2904cc38c334eba4

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -51 lines) Patch
M include/core/SkPaint.h View 1 chunk +1 line, -2 lines 1 comment Download
M src/gpu/text/GrAtlasTextBlob.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/gpu/text/GrAtlasTextBlob.cpp View 1 chunk +16 lines, -0 lines 0 comments Download
M src/gpu/text/GrAtlasTextContext.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/text/GrAtlasTextContext.cpp View 10 chunks +15 lines, -42 lines 0 comments Download
M src/gpu/text/GrTextUtils.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/text/GrTextUtils.cpp View 5 chunks +8 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
joshualitt
Another small cl to further cleanup things by making draw* calls responsible for managing the ...
5 years ago (2015-12-11 17:49:43 UTC) #2
jvanverth1
lgtm https://codereview.chromium.org/1521613002/diff/1/include/core/SkPaint.h File include/core/SkPaint.h (left): https://codereview.chromium.org/1521613002/diff/1/include/core/SkPaint.h#oldcode1092 include/core/SkPaint.h:1092: friend class GrBitmapTextContext; Whoa, archaeology....
5 years ago (2015-12-11 18:29:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521613002/1
5 years ago (2015-12-15 19:18:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/4724)
5 years ago (2015-12-15 19:20:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521613002/1
5 years ago (2015-12-15 19:27:52 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/66957946c0c418e71c0f36bb2904cc38c334eba4
5 years ago (2015-12-15 19:33:22 UTC) #12
joshualitt
4 years, 12 months ago (2015-12-28 15:14:38 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1552513003/ by joshualitt@google.com.

The reason for reverting is: seeing crashes on android and linux.

Powered by Google App Engine
This is Rietveld 408576698