Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 1516943004: Move a bit more logic into GrAtlasTextBlob (Closed)

Created:
5 years ago by joshua.litt
Modified:
4 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@cleanuptext14moredfcleanup
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : a bit more #

Patch Set 3 : more cleanup #

Total comments: 2

Patch Set 4 : comment tweaked #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -90 lines) Patch
M src/gpu/text/GrAtlasTextBlob.h View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M src/gpu/text/GrAtlasTextContext.h View 2 chunks +3 lines, -12 lines 0 comments Download
M src/gpu/text/GrAtlasTextContext.cpp View 1 2 15 chunks +41 lines, -78 lines 0 comments Download
M src/gpu/text/GrTextUtils.cpp View 1 2 chunks +6 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
joshualitt
this change makes df text and bmp text have a common interface. It also has ...
5 years ago (2015-12-11 18:49:03 UTC) #2
joshualitt
On 2015/12/11 18:49:03, joshualitt wrote: > this change makes df text and bmp text have ...
5 years ago (2015-12-15 19:29:55 UTC) #3
bsalomon
https://codereview.chromium.org/1516943004/diff/40001/src/gpu/text/GrAtlasTextBlob.h File src/gpu/text/GrAtlasTextBlob.h (right): https://codereview.chromium.org/1516943004/diff/40001/src/gpu/text/GrAtlasTextBlob.h#newcode293 src/gpu/text/GrAtlasTextBlob.h:293: // sets the last subrun to use distance field ...
5 years ago (2015-12-15 19:43:49 UTC) #4
joshualitt
https://codereview.chromium.org/1516943004/diff/40001/src/gpu/text/GrAtlasTextBlob.h File src/gpu/text/GrAtlasTextBlob.h (right): https://codereview.chromium.org/1516943004/diff/40001/src/gpu/text/GrAtlasTextBlob.h#newcode293 src/gpu/text/GrAtlasTextBlob.h:293: // sets the last subrun to use distance field ...
5 years ago (2015-12-15 19:49:28 UTC) #5
bsalomon
lgtm, but a more meaningful checkin msg would be nice :)
5 years ago (2015-12-17 20:52:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1516943004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1516943004/80001
4 years, 11 months ago (2016-01-19 14:48:12 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 14:59:33 UTC) #13
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/a6bf4c54aaa3c1d1ae33f43af96a294c65bbd8fc

Powered by Google App Engine
This is Rietveld 408576698