Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1519083002: A change to cleanup some organization around df text (Closed)

Created:
5 years ago by joshua.litt
Modified:
5 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@cleanuptext12textutilsdftext
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

A change to cleanup some organization around df text BUG=skia: Committed: https://skia.googlesource.com/skia/+/5425a9a1807b2b2eafdd5c5f4c184f7161807f66

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -86 lines) Patch
M src/gpu/text/GrAtlasTextContext.h View 2 chunks +11 lines, -15 lines 0 comments Download
M src/gpu/text/GrAtlasTextContext.cpp View 14 chunks +50 lines, -71 lines 1 comment Download

Depends on Patchset:

Issue 1521453002 Patch 1

Dependent Patchsets:

Issue 1521613002 Patch 1

Messages

Total messages: 7 (3 generated)
joshualitt
A small change to cleanup some of the odd handling around df text. More patches ...
5 years ago (2015-12-11 16:43:23 UTC) #2
jvanverth1
lgtm https://codereview.chromium.org/1519083002/diff/1/src/gpu/text/GrAtlasTextContext.cpp File src/gpu/text/GrAtlasTextContext.cpp (right): https://codereview.chromium.org/1519083002/diff/1/src/gpu/text/GrAtlasTextContext.cpp#newcode700 src/gpu/text/GrAtlasTextContext.cpp:700: if (fallbackTxt.count()) { +1. This makes a lot ...
5 years ago (2015-12-11 18:12:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1519083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1519083002/1
5 years ago (2015-12-11 18:47:47 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-11 19:05:45 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5425a9a1807b2b2eafdd5c5f4c184f7161807f66

Powered by Google App Engine
This is Rietveld 408576698