MIPS: [turbofan] Optimize Float32 to Int32 rep. changes with Float32 round ops.

MIPS: [turbofan] Optimize Float32 to Int32 rep. changes with Float32 round ops.

TEST=unittests/InstructionSelectorTest.CombineChangeFloat32ToInt32WithRoundFloat32,
     ChangeFloat64ToInt32OfChangeFloat32ToFloat64, TruncateFloat64ToFloat32OfChangeInt32ToFloat64
BUG=

Committed: https://crrev.com/7bc8fac47210ba7c8905b1ac3eb7480cf659ad4f
Cr-Commit-Position: refs/heads/master@{#32969}

[dusan.milosavljevic, 2015-12-10 14:46:05]

dusan.m.milosavljevic@gmail.com changed reviewers:
+ bmeurer@chromium.org, paul.lind@imgtec.com, titzer@chromium.org

[dusan.milosavljevic, 2015-12-10 14:46:05]

PTAL.

[dusan.milosavljevic, 2015-12-15 15:59:32]

PTAL.

[Alan Li, 2015-12-17 02:27:03]

alan.li@imgtec.com changed reviewers:
+ alan.li@imgtec.com

[Alan Li, 2015-12-17 02:27:04]

https://codereview.chromium.org/1520503002/diff/1/src/compiler/mips/instructi...
File src/compiler/mips/instruction-selector-mips.cc (right):

https://codereview.chromium.org/1520503002/diff/1/src/compiler/mips/instructi...
src/compiler/mips/instruction-selector-mips.cc:563: Emit(kMips64TruncWS,
g.DefineAsRegister(node),
For mips32, it seems that you haven't implemented kMips64TruncWS in
code-generator-mips.cc??

[dusan.milosavljevic, 2015-12-17 13:44:10]

https://codereview.chromium.org/1520503002/diff/1/src/compiler/mips/instructi...
File src/compiler/mips/instruction-selector-mips.cc (right):

https://codereview.chromium.org/1520503002/diff/1/src/compiler/mips/instructi...
src/compiler/mips/instruction-selector-mips.cc:563: Emit(kMips64TruncWS,
g.DefineAsRegister(node),
On 2015/12/17 02:27:04, Alan Li wrote:
> For mips32, it seems that you haven't implemented kMips64TruncWS in
> code-generator-mips.cc??

Done.

[Alan Li, 2015-12-17 21:29:24]

On 2015/12/17 13:44:10, dusan.milosavljevic wrote:
>
https://codereview.chromium.org/1520503002/diff/1/src/compiler/mips/instructi...
> File src/compiler/mips/instruction-selector-mips.cc (right):
> 
>
https://codereview.chromium.org/1520503002/diff/1/src/compiler/mips/instructi...
> src/compiler/mips/instruction-selector-mips.cc:563: Emit(kMips64TruncWS,
> g.DefineAsRegister(node),
> On 2015/12/17 02:27:04, Alan Li wrote:
> > For mips32, it seems that you haven't implemented kMips64TruncWS in
> > code-generator-mips.cc??
> 
> Done.

LGTM. Please rebase it.

Tests pass on tot, both 32bit and 64bit (after doing the rebasing locally).

[dusan.milosavljevic, 2015-12-17 23:57:38]

On 2015/12/17 21:29:24, Alan Li wrote:
> On 2015/12/17 13:44:10, dusan.milosavljevic wrote:
> >
>
https://codereview.chromium.org/1520503002/diff/1/src/compiler/mips/instructi...
> > File src/compiler/mips/instruction-selector-mips.cc (right):
> > 
> >
>
https://codereview.chromium.org/1520503002/diff/1/src/compiler/mips/instructi...
> > src/compiler/mips/instruction-selector-mips.cc:563: Emit(kMips64TruncWS,
> > g.DefineAsRegister(node),
> > On 2015/12/17 02:27:04, Alan Li wrote:
> > > For mips32, it seems that you haven't implemented kMips64TruncWS in
> > > code-generator-mips.cc??
> > 
> > Done.
> 
> LGTM. Please rebase it.
> 
> Tests pass on tot, both 32bit and 64bit (after doing the rebasing locally).

Done,

Thank you.

[dusan.milosavljevic, 2015-12-17 23:59:36]

dusan.m.milosavljevic@gmail.com changed reviewers:
+ akos.palfi@imgtec.com, balazs.kilvady@imgtec.com

[dusan.milosavljevic, 2015-12-17 23:59:36]

Adding Akos and Balazs for reviewers.

[akos.palfi.imgtec, 2015-12-18 00:31:44]

https://codereview.chromium.org/1520503002/diff/40001/src/compiler/mips/instr...
File src/compiler/mips/instruction-codes-mips.h (right):

https://codereview.chromium.org/1520503002/diff/40001/src/compiler/mips/instr...
src/compiler/mips/instruction-codes-mips.h:69: V(MipsCvtDS)                    
\
Please add MipsCvtSW.

[dusan.milosavljevic, 2015-12-18 12:22:37]

https://codereview.chromium.org/1520503002/diff/40001/src/compiler/mips/instr...
File src/compiler/mips/instruction-codes-mips.h (right):

https://codereview.chromium.org/1520503002/diff/40001/src/compiler/mips/instr...
src/compiler/mips/instruction-codes-mips.h:69: V(MipsCvtDS)                    
\
On 2015/12/18 00:31:44, akos.palfi.imgtec wrote:
> Please add MipsCvtSW.

Done.

[akos.palfi.imgtec, 2015-12-18 12:23:41]

LGTM.

[dusan.milosavljevic, 2015-12-18 15:36:46]

The CQ bit was checked by dusan.m.milosavljevic@gmail.com

[dusan.milosavljevic, 2015-12-18 15:36:46]

The patchset sent to the CQ was uploaded after l-g-t-m from alan.li@imgtec.com
Link to the patchset: https://codereview.chromium.org/1520503002/#ps60001
(title: "Fix typo.")

[commit-bot: I haz the power, 2015-12-18 15:36:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1520503002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1520503002/60001

[commit-bot: I haz the power, 2015-12-18 16:12:08]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-18 16:13:00]

Description was changed from

==========
MIPS: [turbofan] Optimize Float32 to Int32 rep. changes with Float32 round ops.

TEST=unittests/InstructionSelectorTest.CombineChangeFloat32ToInt32WithRoundFloat32,
     ChangeFloat64ToInt32OfChangeFloat32ToFloat64,
TruncateFloat64ToFloat32OfChangeInt32ToFloat64
BUG=
==========

to

==========
MIPS: [turbofan] Optimize Float32 to Int32 rep. changes with Float32 round ops.

TEST=unittests/InstructionSelectorTest.CombineChangeFloat32ToInt32WithRoundFloat32,
     ChangeFloat64ToInt32OfChangeFloat32ToFloat64,
TruncateFloat64ToFloat32OfChangeInt32ToFloat64
BUG=

Committed: https://crrev.com/7bc8fac47210ba7c8905b1ac3eb7480cf659ad4f
Cr-Commit-Position: refs/heads/master@{#32969}
==========

[commit-bot: I haz the power, 2015-12-18 16:13:01]

Patchset 4 (id:??) landed as
https://crrev.com/7bc8fac47210ba7c8905b1ac3eb7480cf659ad4f
Cr-Commit-Position: refs/heads/master@{#32969}