Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: src/gpu/text/GrAtlasTextContext.h

Issue 1519083002: A change to cleanup some organization around df text (Closed) Base URL: https://skia.googlesource.com/skia.git@cleanuptext12textutilsdftext
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/gpu/text/GrAtlasTextContext.cpp » ('j') | src/gpu/text/GrAtlasTextContext.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/text/GrAtlasTextContext.h
diff --git a/src/gpu/text/GrAtlasTextContext.h b/src/gpu/text/GrAtlasTextContext.h
index 47f05404ded9eaa44a7707dcbad6f9b1fc271318..e38243d4805d5e469df07fa7e93776b43081688b 100644
--- a/src/gpu/text/GrAtlasTextContext.h
+++ b/src/gpu/text/GrAtlasTextContext.h
@@ -66,29 +66,27 @@ private:
// A helper for drawing BitmapText in a run of distance fields
inline void fallbackDrawPosText(GrAtlasTextBlob*, int runIndex,
- const GrClip&, GrColor color,
+ GrColor color,
const SkPaint&, const SkMatrix& viewMatrix,
const SkTDArray<char>& fallbackTxt,
const SkTDArray<SkScalar>& fallbackPos,
int scalarsPerPosition,
const SkPoint& offset);
- void internalDrawDFText(GrAtlasTextBlob*, int runIndex, const SkPaint&,
+ void internalDrawDFText(GrAtlasTextBlob*, int runIndex,
+ SkGlyphCache*, const SkPaint&,
GrColor color, const SkMatrix& viewMatrix,
const char text[], size_t byteLength,
SkScalar x, SkScalar y,
- SkScalar textRatio,
- SkTDArray<char>* fallbackTxt,
- SkTDArray<SkScalar>* fallbackPos,
- SkPoint* offset, const SkPaint& origPaint);
- void internalDrawDFPosText(GrAtlasTextBlob*, int runIndex, const SkPaint&,
+ SkScalar textRatio, const SkPaint& origPaint);
+ void internalDrawDFPosText(GrAtlasTextBlob*, int runIndex,
+ SkGlyphCache*, const SkPaint&,
GrColor color, const SkMatrix& viewMatrix,
const char text[], size_t byteLength,
const SkScalar pos[], int scalarsPerPosition,
const SkPoint& offset,
SkScalar textRatio,
- SkTDArray<char>* fallbackTxt,
- SkTDArray<SkScalar>* fallbackPos);
+ const SkPaint& origPaint);
// sets up the descriptor on the blob and returns a detached cache. Client must attach
inline static GrColor ComputeCanonicalColor(const SkPaint&, bool lcd);
@@ -104,17 +102,15 @@ private:
// Test methods
// TODO this is really ugly. It'd be much nicer if positioning could be moved to batch
- inline GrAtlasTextBlob* createDrawTextBlob(const GrClip&, const GrPaint&,
+ inline GrAtlasTextBlob* createDrawTextBlob(const GrPaint&,
const SkPaint&, const SkMatrix& viewMatrix,
const char text[], size_t byteLength,
- SkScalar x, SkScalar y,
- const SkIRect& regionClipBounds);
- inline GrAtlasTextBlob* createDrawPosTextBlob(const GrClip&, const GrPaint&,
+ SkScalar x, SkScalar y);
+ inline GrAtlasTextBlob* createDrawPosTextBlob(const GrPaint&,
const SkPaint&, const SkMatrix& viewMatrix,
const char text[], size_t byteLength,
const SkScalar pos[], int scalarsPerPosition,
- const SkPoint& offset,
- const SkIRect& regionClipBounds);
+ const SkPoint& offset);
const GrDistanceFieldAdjustTable* dfAdjustTable() const { return fDistanceAdjustTable; }
GrBatchTextStrike* fCurrStrike;
« no previous file with comments | « no previous file | src/gpu/text/GrAtlasTextContext.cpp » ('j') | src/gpu/text/GrAtlasTextContext.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698