Reland of "[cctest] Add tests for aborting compaction of pages"

Reland of "[cctest] Add tests for aborting compaction of pages"

Tests for
* aborting a full page.
* partially aborting a page.
* partially aborting a page with pointers between aborted pages.
* partially aborting a page with store buffer entries.

Also introduces force_oom() which prohibits a old space to
expand

BUG=chromium:524425
LOG=N

CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_nosnap_rel,v8_linux_nosnap_dbg,v8_win_nosnap_shared_rel,v8_win_nosnap_shared_compile_rel

Committed: https://crrev.com/2bb51df9bde1ac79593030e635d7bfafb07b298a
Cr-Commit-Position: refs/heads/master@{#32899}

[Michael Lippautz, 2015-12-11 11:50:02]

Description was changed from

==========
Reland of "[cctest] Add tests for aborting compaction of pages"

BUG=
==========

to

==========
Reland of "[cctest] Add tests for aborting compaction of pages"
Tests for
* aborting a full page.
* partially aborting a page.
* partially aborting a page with pointers between aborted pages.
* partially aborting a page with store buffer entries.

Also introduces force_oom() which prohibits a old space to
expand

BUG=chromium:524425
LOG=N
==========

[Michael Lippautz, 2015-12-11 11:50:09]

Description was changed from

==========
Reland of "[cctest] Add tests for aborting compaction of pages"
Tests for
* aborting a full page.
* partially aborting a page.
* partially aborting a page with pointers between aborted pages.
* partially aborting a page with store buffer entries.

Also introduces force_oom() which prohibits a old space to
expand

BUG=chromium:524425
LOG=N
==========

to

==========
Reland of "[cctest] Add tests for aborting compaction of pages"

Tests for
* aborting a full page.
* partially aborting a page.
* partially aborting a page with pointers between aborted pages.
* partially aborting a page with store buffer entries.

Also introduces force_oom() which prohibits a old space to
expand

BUG=chromium:524425
LOG=N
==========

[Michael Lippautz, 2015-12-11 11:58:44]

mlippautz@chromium.org changed reviewers:
+ hpayer@chromium.org

[Michael Lippautz, 2015-12-11 11:58:44]

PTAL

[Hannes Payer (out of office), 2015-12-11 16:10:38]

https://codereview.chromium.org/1518803005/diff/60001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1518803005/diff/60001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:3681: if (!p->IsFlagSet(Page::NEVER_ALLOCATE_ON_PAGE))
{
I think I would prefer dropping Page::NEVER_ALLOCATE_ON_PAGE free memory blocks
in the free method of the free list.

[Michael Lippautz, 2015-12-16 09:24:56]

PTAL

https://codereview.chromium.org/1518803005/diff/60001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1518803005/diff/60001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:3681: if (!p->IsFlagSet(Page::NEVER_ALLOCATE_ON_PAGE))
{
On 2015/12/11 16:10:37, Hannes Payer wrote:
> I think I would prefer dropping Page::NEVER_ALLOCATE_ON_PAGE free memory
blocks
> in the free method of the free list.

They are already filtered out during free list operations.

I added a section in the initialization of the sweeper that filters out those
special pages and resets their markbits and live bytes.

[Hannes Payer (out of office), 2015-12-16 12:07:15]

https://codereview.chromium.org/1518803005/diff/80001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1518803005/diff/80001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:3781: p->ResetLiveBytes();
Should we really reset live bytes here? That would indicate that everything is
dead on this page.

https://codereview.chromium.org/1518803005/diff/80001/src/heap/spaces.h
File src/heap/spaces.h (right):

https://codereview.chromium.org/1518803005/diff/80001/src/heap/spaces.h#newco...
src/heap/spaces.h:688: bool CanAllocateOnPage() {
Just call it CanAllocate, since it is called on Page.

[Michael Lippautz, 2015-12-16 12:13:14]

https://codereview.chromium.org/1518803005/diff/80001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1518803005/diff/80001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:3781: p->ResetLiveBytes();
On 2015/12/16 12:07:14, Hannes Payer wrote:
> Should we really reset live bytes here? That would indicate that everything is
> dead on this page.

We reset live bytes after sweeping a page. I think we want to do that here since
we don't sweep them but want them to be in the same state as regular pages after
sweeping (i.e. cleared mark bits, reset live byte counter).

https://codereview.chromium.org/1518803005/diff/80001/src/heap/spaces.h
File src/heap/spaces.h (right):

https://codereview.chromium.org/1518803005/diff/80001/src/heap/spaces.h#newco...
src/heap/spaces.h:688: bool CanAllocateOnPage() {
On 2015/12/16 12:07:14, Hannes Payer wrote:
> Just call it CanAllocate, since it is called on Page.

Done.

[Hannes Payer (out of office), 2015-12-16 12:44:00]

lgtm

https://codereview.chromium.org/1518803005/diff/80001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1518803005/diff/80001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:3781: p->ResetLiveBytes();
On 2015/12/16 12:13:14, Michael Lippautz wrote:
> On 2015/12/16 12:07:14, Hannes Payer wrote:
> > Should we really reset live bytes here? That would indicate that everything
is
> > dead on this page.
> 
> We reset live bytes after sweeping a page. I think we want to do that here
since
> we don't sweep them but want them to be in the same state as regular pages
after
> sweeping (i.e. cleared mark bits, reset live byte counter).

Acknowledged.

[Michael Lippautz, 2015-12-16 12:48:19]

Description was changed from

==========
Reland of "[cctest] Add tests for aborting compaction of pages"

Tests for
* aborting a full page.
* partially aborting a page.
* partially aborting a page with pointers between aborted pages.
* partially aborting a page with store buffer entries.

Also introduces force_oom() which prohibits a old space to
expand

BUG=chromium:524425
LOG=N
==========

to

==========
Reland of "[cctest] Add tests for aborting compaction of pages"

Tests for
* aborting a full page.
* partially aborting a page.
* partially aborting a page with pointers between aborted pages.
* partially aborting a page with store buffer entries.

Also introduces force_oom() which prohibits a old space to
expand

BUG=chromium:524425
LOG=N

CQ_EXTRA_TRYBOTS=tryserver.v8:
==========

[Michael Lippautz, 2015-12-16 12:48:46]

Description was changed from

==========
Reland of "[cctest] Add tests for aborting compaction of pages"

Tests for
* aborting a full page.
* partially aborting a page.
* partially aborting a page with pointers between aborted pages.
* partially aborting a page with store buffer entries.

Also introduces force_oom() which prohibits a old space to
expand

BUG=chromium:524425
LOG=N

CQ_EXTRA_TRYBOTS=tryserver.v8:
==========

to

==========
Reland of "[cctest] Add tests for aborting compaction of pages"

Tests for
* aborting a full page.
* partially aborting a page.
* partially aborting a page with pointers between aborted pages.
* partially aborting a page with store buffer entries.

Also introduces force_oom() which prohibits a old space to
expand

BUG=chromium:524425
LOG=N

CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_nosnap_rel,tryserver.v8:v8_linux_nosnap_dbg
==========

[Michael Lippautz, 2015-12-16 12:49:11]

Description was changed from

==========
Reland of "[cctest] Add tests for aborting compaction of pages"

Tests for
* aborting a full page.
* partially aborting a page.
* partially aborting a page with pointers between aborted pages.
* partially aborting a page with store buffer entries.

Also introduces force_oom() which prohibits a old space to
expand

BUG=chromium:524425
LOG=N

CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_nosnap_rel,tryserver.v8:v8_linux_nosnap_dbg
==========

to

==========
Reland of "[cctest] Add tests for aborting compaction of pages"

Tests for
* aborting a full page.
* partially aborting a page.
* partially aborting a page with pointers between aborted pages.
* partially aborting a page with store buffer entries.

Also introduces force_oom() which prohibits a old space to
expand

BUG=chromium:524425
LOG=N

CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_nosnap_rel,tryserver.v8:v8_linux_nosnap_dbg,v8_win_nosnap_shared_rel,v8_win_nosnap_shared_compile_rel
==========

[Michael Lippautz, 2015-12-16 12:49:46]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-16 12:49:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1518803005/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1518803005/100001

[commit-bot: I haz the power, 2015-12-16 12:49:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-16 12:49:51]

Dry run: Transient error: Too many
"tryserver.v8:v8_linux_nosnap_rel,tryserver.v8:v8_linux_nosnap_dbg,v8_win_nosnap_shared_rel,v8_win_nosnap_shared_compile_rel"
delimiters in ":".
Correct syntax is "tryserver:bot1,bot2;tryserver2:bot3,bot4;".

[Michael Lippautz, 2015-12-16 12:50:31]

Description was changed from

==========
Reland of "[cctest] Add tests for aborting compaction of pages"

Tests for
* aborting a full page.
* partially aborting a page.
* partially aborting a page with pointers between aborted pages.
* partially aborting a page with store buffer entries.

Also introduces force_oom() which prohibits a old space to
expand

BUG=chromium:524425
LOG=N

CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_nosnap_rel,tryserver.v8:v8_linux_nosnap_dbg,v8_win_nosnap_shared_rel,v8_win_nosnap_shared_compile_rel
==========

to

==========
Reland of "[cctest] Add tests for aborting compaction of pages"

Tests for
* aborting a full page.
* partially aborting a page.
* partially aborting a page with pointers between aborted pages.
* partially aborting a page with store buffer entries.

Also introduces force_oom() which prohibits a old space to
expand

BUG=chromium:524425
LOG=N

CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_nosnap_rel,tryserver.v8:v8_linux_nosnap_dbg,tryserver.v8:v8_win_nosnap_shared_rel,tryserver.v8:v8_win_nosnap_shared_compile_rel
==========

[Michael Lippautz, 2015-12-16 12:50:37]

The CQ bit was checked by mlippautz@chromium.org

[commit-bot: I haz the power, 2015-12-16 12:50:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1518803005/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1518803005/100001

[commit-bot: I haz the power, 2015-12-16 12:50:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-16 12:50:51]

Transient error: Too many
"tryserver.v8:v8_linux_nosnap_rel,tryserver.v8:v8_linux_nosnap_dbg,tryserver.v8:v8_win_nosnap_shared_rel,tryserver.v8:v8_win_nosnap_shared_compile_rel"
delimiters in ":".
Correct syntax is "tryserver:bot1,bot2;tryserver2:bot3,bot4;".

[Michael Lippautz, 2015-12-16 12:51:37]

Description was changed from

==========
Reland of "[cctest] Add tests for aborting compaction of pages"

Tests for
* aborting a full page.
* partially aborting a page.
* partially aborting a page with pointers between aborted pages.
* partially aborting a page with store buffer entries.

Also introduces force_oom() which prohibits a old space to
expand

BUG=chromium:524425
LOG=N

CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_nosnap_rel,tryserver.v8:v8_linux_nosnap_dbg,tryserver.v8:v8_win_nosnap_shared_rel,tryserver.v8:v8_win_nosnap_shared_compile_rel
==========

to

==========
Reland of "[cctest] Add tests for aborting compaction of pages"

Tests for
* aborting a full page.
* partially aborting a page.
* partially aborting a page with pointers between aborted pages.
* partially aborting a page with store buffer entries.

Also introduces force_oom() which prohibits a old space to
expand

BUG=chromium:524425
LOG=N

CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_nosnap_rel,v8_linux_nosnap_dbg,v8_win_nosnap_shared_rel,v8_win_nosnap_shared_compile_rel
==========

[Michael Lippautz, 2015-12-16 12:51:48]

The CQ bit was checked by mlippautz@chromium.org

[commit-bot: I haz the power, 2015-12-16 12:51:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1518803005/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1518803005/100001

[Michael Lippautz, 2015-12-16 13:26:32]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2015-12-16 13:26:32]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/1518803005/#ps120001
(title: "Sweep NEVER_ALLOCATE_ON_PAGE pages. Memory gets dropped in the free
list again")

[commit-bot: I haz the power, 2015-12-16 13:26:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1518803005/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1518803005/120001

[commit-bot: I haz the power, 2015-12-16 14:06:36]

Description was changed from

==========
Reland of "[cctest] Add tests for aborting compaction of pages"

Tests for
* aborting a full page.
* partially aborting a page.
* partially aborting a page with pointers between aborted pages.
* partially aborting a page with store buffer entries.

Also introduces force_oom() which prohibits a old space to
expand

BUG=chromium:524425
LOG=N

CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_nosnap_rel,v8_linux_nosnap_dbg,v8_win_nosnap_shared_rel,v8_win_nosnap_shared_compile_rel
==========

to

==========
Reland of "[cctest] Add tests for aborting compaction of pages"

Tests for
* aborting a full page.
* partially aborting a page.
* partially aborting a page with pointers between aborted pages.
* partially aborting a page with store buffer entries.

Also introduces force_oom() which prohibits a old space to
expand

BUG=chromium:524425
LOG=N

CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_nosnap_rel,v8_linux_nosnap_dbg,v8_win_nosnap_shared_rel,v8_win_nosnap_shared_compile_rel
==========

[commit-bot: I haz the power, 2015-12-16 14:06:37]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-12-16 14:07:01]

Description was changed from

==========
Reland of "[cctest] Add tests for aborting compaction of pages"

Tests for
* aborting a full page.
* partially aborting a page.
* partially aborting a page with pointers between aborted pages.
* partially aborting a page with store buffer entries.

Also introduces force_oom() which prohibits a old space to
expand

BUG=chromium:524425
LOG=N

CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_nosnap_rel,v8_linux_nosnap_dbg,v8_win_nosnap_shared_rel,v8_win_nosnap_shared_compile_rel
==========

to

==========
Reland of "[cctest] Add tests for aborting compaction of pages"

Tests for
* aborting a full page.
* partially aborting a page.
* partially aborting a page with pointers between aborted pages.
* partially aborting a page with store buffer entries.

Also introduces force_oom() which prohibits a old space to
expand

BUG=chromium:524425
LOG=N

CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_nosnap_rel,v8_linux_nosnap_dbg,v8_win_nosnap_shared_rel,v8_win_nosnap_shared_compile_rel

Committed: https://crrev.com/2bb51df9bde1ac79593030e635d7bfafb07b298a
Cr-Commit-Position: refs/heads/master@{#32899}
==========

[commit-bot: I haz the power, 2015-12-16 14:07:02]

Patchset 7 (id:??) landed as
https://crrev.com/2bb51df9bde1ac79593030e635d7bfafb07b298a
Cr-Commit-Position: refs/heads/master@{#32899}