Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1514933002: Create GrTextUtils (Closed)

Created:
5 years ago by joshua.litt
Modified:
5 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@cleanuptext9
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -138 lines) Patch
M gyp/gpu.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M include/core/SkPaint.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAtlasTextBlob.h View 2 chunks +4 lines, -5 lines 0 comments Download
M src/gpu/GrAtlasTextBlob.cpp View 4 chunks +8 lines, -9 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTextContext.h View 1 chunk +0 lines, -13 lines 0 comments Download
M src/gpu/GrTextContext.cpp View 4 chunks +5 lines, -109 lines 0 comments Download
A src/gpu/GrTextUtils.h View 1 chunk +45 lines, -0 lines 0 comments Download
A src/gpu/GrTextUtils.cpp View 1 chunk +94 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1518763002 Patch 40001

Dependent Patchsets:

Issue 1518883002 Patch 1

Messages

Total messages: 8 (3 generated)
joshualitt
This just creates GrTextUtils and moves the path drawing code to it.
5 years ago (2015-12-10 19:57:15 UTC) #2
bsalomon
lgtm
5 years ago (2015-12-10 20:51:36 UTC) #3
jvanverth1
lgtm
5 years ago (2015-12-10 20:57:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1514933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1514933002/1
5 years ago (2015-12-10 21:04:43 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-10 21:21:01 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0a42e6827b178468105343ffdf40b011b7ba283c

Powered by Google App Engine
This is Rietveld 408576698