Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1518673002: Remove dummy control / effect edges from RMA Call nodes. (Closed)

Created:
5 years ago by rmcilroy
Modified:
5 years ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove dummy control / effect edges from RMA Call nodes. Removes the dummy control and effect edges from the RMA Call nodes. This requires a change to the node matchers to allow them to cope with nodes which don't have control or effect matchers. Committed: https://crrev.com/c4745aa187d750d9c522cdda0ee3a2eb2708ccdf Cr-Commit-Position: refs/heads/master@{#32752}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -76 lines) Patch
M src/compiler/raw-machine-assembler.cc View 13 chunks +12 lines, -35 lines 0 comments Download
M test/unittests/compiler/interpreter-assembler-unittest.h View 1 chunk +0 lines, -4 lines 0 comments Download
M test/unittests/compiler/interpreter-assembler-unittest.cc View 10 chunks +21 lines, -29 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 2 chunks +24 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518673002/1
5 years ago (2015-12-10 12:37:58 UTC) #2
rmcilroy
Michi PTAL, thanks.
5 years ago (2015-12-10 12:38:42 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-10 13:04:52 UTC) #6
Michael Starzinger
LGTM. Thanks!
5 years ago (2015-12-10 13:32:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518673002/1
5 years ago (2015-12-10 13:35:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 13:36:23 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-10 13:36:36 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c4745aa187d750d9c522cdda0ee3a2eb2708ccdf
Cr-Commit-Position: refs/heads/master@{#32752}

Powered by Google App Engine
This is Rietveld 408576698