Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1510173004: Remove dummy control / effect edges from RMA Load / Store / Div nodes. (Closed)

Created:
5 years ago by rmcilroy
Modified:
5 years ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@rma_edges_calls
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove dummy control / effect edges from RMA Load / Store / Div nodes. Committed: https://crrev.com/42718a4c889bbdede2aa23e9be602e5826216149 Cr-Commit-Position: refs/heads/master@{#32762}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -19 lines) Patch
M src/compiler/raw-machine-assembler.h View 5 chunks +6 lines, -7 lines 0 comments Download
M test/unittests/compiler/interpreter-assembler-unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 4 chunks +24 lines, -8 lines 0 comments Download

Depends on Patchset:

Issue 1518673002 Patch 1

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510173004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510173004/1
5 years ago (2015-12-10 15:08:55 UTC) #2
rmcilroy
Michi, PTAL, thanks.
5 years ago (2015-12-10 15:10:48 UTC) #4
Michael Starzinger
LGTM. Thanks!
5 years ago (2015-12-10 15:42:41 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-10 16:09:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1510173004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1510173004/1
5 years ago (2015-12-10 16:27:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 17:07:20 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-10 17:07:47 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/42718a4c889bbdede2aa23e9be602e5826216149
Cr-Commit-Position: refs/heads/master@{#32762}

Powered by Google App Engine
This is Rietveld 408576698