[tools] Fix tools/bash-completion.sh for bool flags and harmony features

[tools] Fix tools/bash-completion.sh for bool flags and harmony features

NOTRY=true

Committed: https://crrev.com/1e9c4b448f889c25045e4c06fd8d5f555a36d556
Cr-Commit-Position: refs/heads/master@{#32740}

[Jakob Kummerow, 2015-12-10 09:44:36]

jkummerow@chromium.org changed reviewers:
+ yangguo@chromium.org

[Jakob Kummerow, 2015-12-10 09:44:37]

https://codereview.chromium.org/1518663002/diff/20001/tools/bash-completion.sh
File tools/bash-completion.sh (right):

https://codereview.chromium.org/1518663002/diff/20001/tools/bash-completion.s...
tools/bash-completion.sh:45: | grep "^  V(harmony_" \
Harmony feature flags are generated by a macro, so grepping for "DEFINE_BOOL"
won't find them...

https://codereview.chromium.org/1518663002/diff/20001/tools/bash-completion.s...
tools/bash-completion.sh:46: | sed -e 's/^  V/DEFINE-BOOL/' \
...but we can use "sed" as a poor man's macro expansion simulation tool :-)

https://codereview.chromium.org/1518663002/diff/20001/tools/bash-completion.s...
tools/bash-completion.sh:51: | sed -ne 's/^DEFINE-BOOL(\([^,]*\).*/--no\1/p'; \
Remember https://codereview.chromium.org/259573003 ?

[Yang, 2015-12-10 09:54:17]

lgtm. Alternatively we could parse `d8 --help` :)

[Jakob Kummerow, 2015-12-10 09:59:37]

> Alternatively we could parse `d8 --help` :)

Sure. Let's do that when the current approach needs a major fix. This patch here
was easy :-)

[Jakob Kummerow, 2015-12-10 09:59:42]

The CQ bit was checked by jkummerow@chromium.org

[commit-bot: I haz the power, 2015-12-10 09:59:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1518663002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1518663002/20001

[commit-bot: I haz the power, 2015-12-10 10:01:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-10 10:01:47]

Description was changed from

==========
[tools] Fix tools/bash-completion.sh for bool flags and harmony features

NOTRY=true
==========

to

==========
[tools] Fix tools/bash-completion.sh for bool flags and harmony features

NOTRY=true

Committed: https://crrev.com/1e9c4b448f889c25045e4c06fd8d5f555a36d556
Cr-Commit-Position: refs/heads/master@{#32740}
==========

[commit-bot: I haz the power, 2015-12-10 10:01:47]

Patchset 2 (id:??) landed as
https://crrev.com/1e9c4b448f889c25045e4c06fd8d5f555a36d556
Cr-Commit-Position: refs/heads/master@{#32740}