Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 259573003: Make flag definition macros style guide compliant and clang-format it. (Closed)

Created:
6 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Make flag definition macros style guide compliant and clang-format it. coding style wants macros to be all upper case, and so clang-format only detects those as macros. BUG=none R=jkummerow@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=22164

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+444 lines, -446 lines) Patch
M src/flag-definitions.h View 1 13 chunks +444 lines, -446 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 8 months ago (2014-04-24 11:50:53 UTC) #1
Jakob Kummerow
lgtm
6 years, 8 months ago (2014-04-24 13:42:48 UTC) #2
jochen (gone - plz use gerrit)
6 years, 5 months ago (2014-07-02 14:00:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22164 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698