[tools] Fix tools/bash-completion.sh for bool flags and harmony features

tools/bash-completion.sh

 #!/bin/bash
 # Copyright 2012 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 #       copyright notice, this list of conditions and the following
@@ skipping 21 matching lines @@
 # Flag completion rule for bash.
 # To load in your shell, "source path/to/this/file".
 
 v8_source=$(readlink -f $(dirname $BASH_SOURCE)/..)
 
 _v8_flag() {
   local cur defines targets
   cur="${COMP_WORDS[COMP_CWORD]}"
   defines=$(cat $v8_source/src/flag-definitions.h \
     | grep "^DEFINE" \
-    | grep -v "DEFINE_implication" \
+    | grep -v "DEFINE_IMPLICATION" \
+    | sed -e 's/_/-/g'; \
+    cat $v8_source/src/flag-definitions.h \
+    | grep "^  V(harmony_" \

[Jakob Kummerow, 2015/12/10 09:44:36]

Harmony feature flags are generated by a macro, so grepping for "DEFINE_BOOL"
won't find them...

+    | sed -e 's/^  V/DEFINE-BOOL/' \

[Jakob Kummerow, 2015/12/10 09:44:36]

...but we can use "sed" as a poor man's macro expansion simulation tool :-)

     | sed -e 's/_/-/g')
   targets=$(echo "$defines" \
     | sed -ne 's/^DEFINE-[^(]*(\([^,]*\).*/--\1/p'; \
     echo "$defines" \
-    | sed -ne 's/^DEFINE-bool(\([^,]*\).*/--no\1/p'; \
+    | sed -ne 's/^DEFINE-BOOL(\([^,]*\).*/--no\1/p'; \

[Jakob Kummerow, 2015/12/10 09:44:36]

Remember https://codereview.chromium.org/259573003 ?

     cat $v8_source/src/d8.cc \
     | grep "strcmp(argv\[i\]" \
     | sed -ne 's/^[^"]*"--\([^"]*\)".*/--\1/p')
   COMPREPLY=($(compgen -W "$targets" -- "$cur"))
   return 0
 }
 
 complete -F _v8_flag -f d8