Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15183002: Clear SVGInlineTextBox fragments when the text changes. (Closed)

Created:
7 years, 7 months ago by Stephen Chennney
Modified:
7 years, 7 months ago
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, f(malita), jchaffraix+rendering, pdr, eseidel
Visibility:
Public.

Description

Clear SVGInlineTextBox fragments when the text changes. This patch modifies SVGInlineTextBox::dirtyLineBoxes to clear all following text boxes when invoked. Typically this method is called when the underlying text string changes, and that change needs to be propagated to all the boxes that use the text beyond the point where the text is first modified. Also cleans up virtual, OVERRIDE and FINAL for SVGRootInlineBox, which was all messed up. R=inferno@chromium.org,leviw@chromium.org BUG=233848 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150456

Patch Set 1 #

Total comments: 8

Patch Set 2 : Revised per reviewer comments. #

Total comments: 4

Patch Set 3 : Removed unused files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -7 lines) Patch
A LayoutTests/svg/custom/unicode-in-tspan-multi-svg-crash.html View 1 1 chunk +38 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/unicode-in-tspan-multi-svg-crash-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/svg/SVGInlineTextBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGInlineTextBox.cpp View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/SVGRootInlineBox.h View 1 2 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
leviw_travelin_and_unemployed
https://codereview.chromium.org/15183002/diff/1/LayoutTests/svg/custom/unicode-in-tspan-multi-svg-crash.html File LayoutTests/svg/custom/unicode-in-tspan-multi-svg-crash.html (right): https://codereview.chromium.org/15183002/diff/1/LayoutTests/svg/custom/unicode-in-tspan-multi-svg-crash.html#newcode1 LayoutTests/svg/custom/unicode-in-tspan-multi-svg-crash.html:1: <html> Doctype? https://codereview.chromium.org/15183002/diff/1/Source/core/rendering/svg/SVGInlineTextBox.cpp File Source/core/rendering/svg/SVGInlineTextBox.cpp (right): https://codereview.chromium.org/15183002/diff/1/Source/core/rendering/svg/SVGInlineTextBox.cpp#newcode75 Source/core/rendering/svg/SVGInlineTextBox.cpp:75: if ...
7 years, 7 months ago (2013-05-14 23:43:41 UTC) #1
pdr.
https://codereview.chromium.org/15183002/diff/1/LayoutTests/svg/custom/unicode-in-tspan-multi-svg-crash.html File LayoutTests/svg/custom/unicode-in-tspan-multi-svg-crash.html (right): https://codereview.chromium.org/15183002/diff/1/LayoutTests/svg/custom/unicode-in-tspan-multi-svg-crash.html#newcode2 LayoutTests/svg/custom/unicode-in-tspan-multi-svg-crash.html:2: <script> Nit: please unify the indentation of this file. ...
7 years, 7 months ago (2013-05-14 23:51:36 UTC) #2
Stephen Chennney
https://codereview.chromium.org/15183002/diff/1/LayoutTests/svg/custom/unicode-in-tspan-multi-svg-crash.html File LayoutTests/svg/custom/unicode-in-tspan-multi-svg-crash.html (right): https://codereview.chromium.org/15183002/diff/1/LayoutTests/svg/custom/unicode-in-tspan-multi-svg-crash.html#newcode1 LayoutTests/svg/custom/unicode-in-tspan-multi-svg-crash.html:1: <html> On 2013/05/14 23:43:41, Levi wrote: > Doctype? Done. ...
7 years, 7 months ago (2013-05-15 00:46:37 UTC) #3
Stephen Chennney
Bump.
7 years, 7 months ago (2013-05-15 18:22:52 UTC) #4
eseidel
https://codereview.chromium.org/15183002/diff/7001/Source/core/rendering/svg/SVGInlineTextBox.cpp File Source/core/rendering/svg/SVGInlineTextBox.cpp (right): https://codereview.chromium.org/15183002/diff/7001/Source/core/rendering/svg/SVGInlineTextBox.cpp#newcode72 Source/core/rendering/svg/SVGInlineTextBox.cpp:72: // And clear any following text fragments as the ...
7 years, 7 months ago (2013-05-15 18:35:01 UTC) #5
Stephen Chennney
https://codereview.chromium.org/15183002/diff/7001/Source/core/rendering/svg/SVGInlineTextBox.cpp File Source/core/rendering/svg/SVGInlineTextBox.cpp (right): https://codereview.chromium.org/15183002/diff/7001/Source/core/rendering/svg/SVGInlineTextBox.cpp#newcode72 Source/core/rendering/svg/SVGInlineTextBox.cpp:72: // And clear any following text fragments as the ...
7 years, 7 months ago (2013-05-15 19:16:46 UTC) #6
eseidel
Marking a linebox as dirty I believe always results in its deletion (at least in ...
7 years, 7 months ago (2013-05-15 19:20:40 UTC) #7
Stephen Chennney
On 2013/05/15 19:20:40, eseidel wrote: > Marking a linebox as dirty I believe always results ...
7 years, 7 months ago (2013-05-15 20:08:31 UTC) #8
Stephen Chennney
I believe that this is the right fix. Due to Glyph offset arrays, and other ...
7 years, 7 months ago (2013-05-15 21:54:29 UTC) #9
eseidel
lgtm
7 years, 7 months ago (2013-05-15 22:20:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/schenney@chromium.org/15183002/17001
7 years, 7 months ago (2013-05-15 22:20:37 UTC) #11
commit-bot: I haz the power
7 years, 7 months ago (2013-05-15 22:41:22 UTC) #12
Message was sent while issue was closed. 
Change committed as 150456

Powered by Google App Engine
This is Rietveld 408576698