LayoutTests/svg/custom/unicode-in-tspan-multi-svg-crash.html - Issue 15183002: Clear SVGInlineTextBox fragments when the text changes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/svg/custom/unicode-in-tspan-multi-svg-crash.html

Issue 15183002: Clear SVGInlineTextBox fragments when the text changes. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <html>
	leviw_travelin_and_unemployed 2013/05/14 23:43:41 Doctype? Doctype? Stephen Chennney 2013/05/15 00:46:37 Done. Show quoted text On 2013/05/14 23:43:41, Levi wrote: > Doctype? Done.
	2 <script>
	pdr. 2013/05/14 23:51:36 Nit: please unify the indentation of this file. Nit: please unify the indentation of this file. Stephen Chennney 2013/05/15 00:46:37 Done. Show quoted text On 2013/05/14 23:51:36, pdr wrote: > Nit: please unify the indentation of this file. Done.
	3 if (window.testRunner)

	4 testRunner.dumpAsText(false);

	5

	6 onload = function() {

	7 tSpanElement = document.getElementById('tSpanInFirstRoot');

	8 tSpanElement.appendChild(document.createTextNode(unescape('%ufe9e%ue 28f%ue47e')));

	9

	10 document.body.offsetTop;

	11 document.body.style.zoom=0.9;

	12

	13 document.designMode='on';

	14 filterInFirstRoot = document.getElementById('filterInFirstRoot');

	15 useElement = document.getElementById('useElement');

	16 window.getSelection().setBaseAndExtent(filterInFirstRoot, useElement , 5);

	17 document.execCommand('ForwardDelete');

	18 document.designMode='off';

	19 }

	20 </script>

	21 <body>

	22 <svg xmlns="http://www.w3.org/2000/svg">

	23 <text>
	pdr. 2013/05/14 23:51:36 The SVG content model should make this filter a no The SVG content model should make this filter a no-op, as <filter>s shouldn't be children of <text>. Can you help me understand why it isn't? Stephen Chennney 2013/05/15 00:46:37 It probably is a no-op, but it affects the selecti Show quoted text On 2013/05/14 23:51:36, pdr wrote: > The SVG content model should make this filter a no-op, as <filter>s shouldn't be > children of <text>. Can you help me understand why it isn't? It probably is a no-op, but it affects the selection and edit operation that triggers the crash, so I do not want to remove it.
	24 <filter id="filterInFirstRoot"/>

	25 <tspan id="tSpanInFirstRoot"/>

	26 </text>

	27 <path filter="url(#filterInSecondRoot)"/>

	28 </svg>

	29

	30 <svg xmlns="http://www.w3.org/2000/svg">

	31 <use id="useElement"/>

	32 <filter id="filterInSecondRoot"/>

	33 </svg>

	34

	35 <p>Test Passes if there is no crash in Debug or Asan builds. There should be n o characters preceding "Test".</p>

	36 </body>

	37 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/svg/custom/unicode-in-tspan-multi-svg-crash-expected.txt » ('j') | Source/core/rendering/svg/SVGInlineTextBox.cpp » ('J')