Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: Source/core/rendering/svg/SVGRootInlineBox.h

Issue 15183002: Clear SVGInlineTextBox fragments when the text changes. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Revised per reviewer comments. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Oliver Hunt <ojh16@student.canterbury.ac.nz> 2 * Copyright (C) 2006 Oliver Hunt <ojh16@student.canterbury.ac.nz>
3 * Copyright (C) 2006 Apple Computer Inc. 3 * Copyright (C) 2006 Apple Computer Inc.
4 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org> 4 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org>
5 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 5 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 22 matching lines...) Expand all
33 class SVGInlineTextBox; 33 class SVGInlineTextBox;
34 34
35 class SVGRootInlineBox FINAL : public RootInlineBox { 35 class SVGRootInlineBox FINAL : public RootInlineBox {
36 public: 36 public:
37 SVGRootInlineBox(RenderBlock* block) 37 SVGRootInlineBox(RenderBlock* block)
38 : RootInlineBox(block) 38 : RootInlineBox(block)
39 , m_logicalHeight(0) 39 , m_logicalHeight(0)
40 { 40 {
41 } 41 }
42 42
43 virtual bool isSVGRootInlineBox() const { return true; } 43 virtual bool isSVGRootInlineBox() const OVERRIDE FINAL { return true; }
44 44
45 virtual float virtualLogicalHeight() const { return m_logicalHeight; } 45 virtual float virtualLogicalHeight() const OVERRIDE FINAL { return m_logical Height; }
46 void setLogicalHeight(float height) { m_logicalHeight = height; } 46 void setLogicalHeight(float height) { m_logicalHeight = height; }
47 47
48 virtual void paint(PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, Layou tUnit lineBottom); 48 virtual void paint(PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, Layou tUnit lineBottom) OVERRIDE FINAL;
49 49
50 void computePerCharacterLayoutInformation(); 50 void computePerCharacterLayoutInformation();
51 51
52 virtual FloatRect objectBoundingBox() const { return FloatRect(); } 52 FloatRect objectBoundingBox() const { return FloatRect(); }
eseidel 2013/05/15 18:35:01 Why are these implemented if not virtual?
Stephen Chennney 2013/05/15 19:16:46 Looks like they are not used at all. I'll delete t
53 virtual FloatRect repaintRectInLocalCoordinates() const { return FloatRect() ; } 53 FloatRect repaintRectInLocalCoordinates() const { return FloatRect(); }
54 54
55 InlineBox* closestLeafChildForPosition(const LayoutPoint&); 55 InlineBox* closestLeafChildForPosition(const LayoutPoint&);
56 56
57 private: 57 private:
58 void reorderValueLists(Vector<SVGTextLayoutAttributes*>&); 58 void reorderValueLists(Vector<SVGTextLayoutAttributes*>&);
59 void layoutCharactersInTextBoxes(InlineFlowBox*, SVGTextLayoutEngine&); 59 void layoutCharactersInTextBoxes(InlineFlowBox*, SVGTextLayoutEngine&);
60 void layoutChildBoxes(InlineFlowBox*, FloatRect* = 0); 60 void layoutChildBoxes(InlineFlowBox*, FloatRect* = 0);
61 void layoutRootBox(const FloatRect&); 61 void layoutRootBox(const FloatRect&);
62 62
63 private: 63 private:
64 float m_logicalHeight; 64 float m_logicalHeight;
65 }; 65 };
66 66
67 } // namespace WebCore 67 } // namespace WebCore
68 68
69 #endif // ENABLE(SVG) 69 #endif // ENABLE(SVG)
70 70
71 #endif // SVGRootInlineBox_h 71 #endif // SVGRootInlineBox_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698