tools/gn: depend on malloc_dump_provider.cc to keep bootstrap working

tools/gn: depend on malloc_dump_provider.cc to keep bootstrap working

This patch adds the missing base/trace_event/malloc_dump_provider.cc to
the sources list to keep the boostrap process working and to fix the
undefined reference error as below:

Undefined symbols for architecture x86_64:
  "base::trace_event::MallocDumpProvider::GetInstance()", referenced from:
      base::trace_event::MemoryDumpManager::Initialize(base::trace_event::MemoryDumpManagerDelegate*, bool) in base.a(memory_dump_manager.o)
  "base::trace_event::MallocDumpProvider::kAllocatedObjects", referenced from:
      base::trace_event::MemoryDumpManager::kSystemAllocatorPoolName in base.a(memory_dump_manager.o)

BUG=568437
TEST=./tools/gn/bootstrap/bootstrap.py
TBR=brettw@chromium.org

Committed: https://crrev.com/8c8cc28366502d308586eec95f8ad919c6dc7ab4
Cr-Commit-Position: refs/heads/master@{#364802}

[tfarina, 2015-12-11 20:03:47]

TBRing...

[tfarina, 2015-12-11 20:03:59]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2015-12-11 20:06:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1517983003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1517983003/1

[brettw, 2015-12-11 20:06:33]

lgtm

[commit-bot: I haz the power, 2015-12-11 21:13:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-11 21:15:34]

Description was changed from

==========
tools/gn: depend on malloc_dump_provider.cc to keep bootstrap working

This patch adds the missing base/trace_event/malloc_dump_provider.cc to
the sources list to keep the boostrap process working and to fix the
undefined reference error as below:

Undefined symbols for architecture x86_64:
  "base::trace_event::MallocDumpProvider::GetInstance()", referenced from:
     
base::trace_event::MemoryDumpManager::Initialize(base::trace_event::MemoryDumpManagerDelegate*,
bool) in base.a(memory_dump_manager.o)
  "base::trace_event::MallocDumpProvider::kAllocatedObjects", referenced from:
      base::trace_event::MemoryDumpManager::kSystemAllocatorPoolName in
base.a(memory_dump_manager.o)

BUG=568437
TEST=./tools/gn/bootstrap/bootstrap.py
TBR=brettw@chromium.org
==========

to

==========
tools/gn: depend on malloc_dump_provider.cc to keep bootstrap working

This patch adds the missing base/trace_event/malloc_dump_provider.cc to
the sources list to keep the boostrap process working and to fix the
undefined reference error as below:

Undefined symbols for architecture x86_64:
  "base::trace_event::MallocDumpProvider::GetInstance()", referenced from:
     
base::trace_event::MemoryDumpManager::Initialize(base::trace_event::MemoryDumpManagerDelegate*,
bool) in base.a(memory_dump_manager.o)
  "base::trace_event::MallocDumpProvider::kAllocatedObjects", referenced from:
      base::trace_event::MemoryDumpManager::kSystemAllocatorPoolName in
base.a(memory_dump_manager.o)

BUG=568437
TEST=./tools/gn/bootstrap/bootstrap.py
TBR=brettw@chromium.org

Committed: https://crrev.com/8c8cc28366502d308586eec95f8ad919c6dc7ab4
Cr-Commit-Position: refs/heads/master@{#364802}
==========

[commit-bot: I haz the power, 2015-12-11 21:15:34]

Patchset 1 (id:??) landed as
https://crrev.com/8c8cc28366502d308586eec95f8ad919c6dc7ab4
Cr-Commit-Position: refs/heads/master@{#364802}

[ionlupascu, 2015-12-11 21:48:17]

ionlupascu@gmail.com changed reviewers:
+ ionlupascu@gmail.com

[ionlupascu, 2015-12-11 21:48:17]

Please apply a correct fix by not braking windows build.

https://codereview.chromium.org/1517983003/diff/1/tools/gn/bootstrap/bootstra...
File tools/gn/bootstrap/bootstrap.py (right):

https://codereview.chromium.org/1517983003/diff/1/tools/gn/bootstrap/bootstra...
tools/gn/bootstrap/bootstrap.py:251: 'base/trace_event/malloc_dump_provider.cc',
Your fix is wrong.
By doing this you brake windows build.

please add it to the to mac specific. On linux is already added.

https://codereview.chromium.org/1517983003/diff/1/tools/gn/bootstrap/bootstra...
tools/gn/bootstrap/bootstrap.py:344: 'base/trace_event/malloc_dump_provider.cc',
Under linux is already added. This is good.

https://codereview.chromium.org/1517983003/diff/1/tools/gn/bootstrap/bootstra...
tools/gn/bootstrap/bootstrap.py:372: 'base/threading/platform_thread_mac.mm',
Here should be the correct fix.

[tfarina, 2015-12-11 22:18:24]

https://codereview.chromium.org/1517983003/diff/1/tools/gn/bootstrap/bootstra...
File tools/gn/bootstrap/bootstrap.py (right):

https://codereview.chromium.org/1517983003/diff/1/tools/gn/bootstrap/bootstra...
tools/gn/bootstrap/bootstrap.py:251: 'base/trace_event/malloc_dump_provider.cc',
On 2015/12/11 21:48:17, ionlupascu wrote:
> Your fix is wrong.
> By doing this you brake windows build.
> 
> please add it to the to mac specific. On linux is already added.

Done. https://codereview.chromium.org/1521063002