tools/gn/bootstrap/bootstrap.py - Issue 1517983003: tools/gn: depend on malloc_dump_provider.cc to keep bootstrap working

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/bootstrap/bootstrap.py

Issue 1517983003: tools/gn: depend on malloc_dump_provider.cc to keep bootstrap working (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/bootstrap/bootstrap.py

diff --git a/tools/gn/bootstrap/bootstrap.py b/tools/gn/bootstrap/bootstrap.py

index 56567aa1f97d1e806c189c6f0b64445fcf60f0da..f6620f7b238940b1ea215a8b781910f38af487ea 100755

--- a/tools/gn/bootstrap/bootstrap.py

+++ b/tools/gn/bootstrap/bootstrap.py

@@ -248,6 +248,7 @@ def write_ninja(path, options):

'base/trace_event/heap_profiler_allocation_context_tracker.cc',

'base/trace_event/heap_profiler_stack_frame_deduplicator.cc',

'base/trace_event/heap_profiler_type_name_deduplicator.cc',

+ 'base/trace_event/malloc_dump_provider.cc',

ionlupascu 2015/12/11 21:48:17 Your fix is wrong. By doing this you brake windows

tfarina 2015/12/11 22:18:24 Done. https://codereview.chromium.org/1521063002

'base/trace_event/memory_allocator_dump.cc',

'base/trace_event/memory_allocator_dump_guid.cc',

'base/trace_event/memory_dump_manager.cc',

« no previous file with comments | « no previous file | no next file » | no next file with comments »