Issue 1521063002: tools/gn: do not break bootstrap process on Windows

Issue 1521063002: tools/gn: do not break bootstrap process on Windows (Closed)

Created:
5 years ago by tfarina

Modified:
5 years ago

Reviewers:
brettw

CC:
chromium-reviews, tfarina, Dirk Pranke, ionlupascu

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

tools/gn: do not break bootstrap process on Windows malloc_dump_provider.cc should be built only on Linux or Mac. BUG=568437 TBR=brettw@chromium.org Committed: https://crrev.com/4514a7974f1acd2cd696aa3e1833c2e7be970668 Cr-Commit-Position: refs/heads/master@{#364841}

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/gn/bootstrap/bootstrap.py	View		2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 8 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1521063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1521063002/1

5 years ago (2015-12-11 22:19:17 UTC) #3

commit-bot: I haz the power

5 years ago (2015-12-11 23:58:45 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/4514a7974f1acd2cd696aa3e1833c2e7be970668
Cr-Commit-Position: refs/heads/master@{#364841}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages