Fix Object.prototype.toString.call(proxy)

Fix Object.prototype.toString.call(proxy)

BUG=

Committed: https://crrev.com/a1e9ccf90fb34190fb23df5b07582313c9efd7b6
Cr-Commit-Position: refs/heads/master@{#32806}

[Toon Verwaest, 2015-12-10 15:38:27]

Patchset #2 (id:20001) has been deleted

[Toon Verwaest, 2015-12-10 15:38:34]

Patchset #1 (id:1) has been deleted

[Toon Verwaest, 2015-12-10 17:23:39]

Patchset #1 (id:40001) has been deleted

[Toon Verwaest, 2015-12-10 18:25:54]

Patchset #2 (id:80001) has been deleted

[Toon Verwaest, 2015-12-10 18:26:10]

Patchset #1 (id:60001) has been deleted

[Toon Verwaest, 2015-12-10 18:26:22]

Patchset #1 (id:100001) has been deleted

[Toon Verwaest, 2015-12-10 18:30:20]

Patchset #1 (id:120001) has been deleted

[Toon Verwaest, 2015-12-10 18:37:20]

Patchset #2 (id:160001) has been deleted

[Toon Verwaest, 2015-12-10 18:37:26]

Patchset #1 (id:140001) has been deleted

[Toon Verwaest, 2015-12-10 18:37:51]

verwaest@chromium.org changed reviewers:
+ cbruni@chromium.org

[Toon Verwaest, 2015-12-10 18:37:52]

ptal

[Camillo Bruni, 2015-12-11 12:37:27]

LGTM with comment

https://codereview.chromium.org/1517673002/diff/180001/src/crankshaft/x87/lit...
File src/crankshaft/x87/lithium-codegen-x87.cc (right):

https://codereview.chromium.org/1517673002/diff/180001/src/crankshaft/x87/lit...
src/crankshaft/x87/lithium-codegen-x87.cc:2733:
STATIC_ASSERT(LAST_JS_RECEIVER_TYPE == LAST_TYPE);
It would probably make some things easier by having JS_PROXY_TYPE and
JS_FUNCTION_TYPE next to each other ;)

https://codereview.chromium.org/1517673002/diff/180001/src/crankshaft/x87/lit...
src/crankshaft/x87/lithium-codegen-x87.cc:2736: __ CmpInstanceType(temp,
LAST_JS_RECEIVER_TYPE);
Why don't we compare directly with JS_FUNCTION_TYPE here? If so you have to
change the assert above again... :P, so probably, no :P

[Toon Verwaest, 2015-12-11 15:36:29]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2015-12-11 15:36:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1517673002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1517673002/180001

[commit-bot: I haz the power, 2015-12-11 15:56:46]

Committed patchset #1 (id:180001)

[commit-bot: I haz the power, 2015-12-11 15:57:37]

Description was changed from

==========
Fix Object.prototype.toString.call(proxy)

BUG=
==========

to

==========
Fix Object.prototype.toString.call(proxy)

BUG=

Committed: https://crrev.com/a1e9ccf90fb34190fb23df5b07582313c9efd7b6
Cr-Commit-Position: refs/heads/master@{#32806}
==========

[commit-bot: I haz the power, 2015-12-11 15:57:38]

Patchset 1 (id:??) landed as
https://crrev.com/a1e9ccf90fb34190fb23df5b07582313c9efd7b6
Cr-Commit-Position: refs/heads/master@{#32806}

[adamk, 2015-12-11 19:25:02]

adamk@chromium.org changed reviewers:
+ adamk@chromium.org

[adamk, 2015-12-11 19:25:03]

I think this is already out of date, though, now that O.p.toString doesn't use
%_ClassOf. I'll send a fix (and more tests).

[adamk, 2015-12-11 19:32:49]

On 2015/12/11 19:25:03, adamk wrote:
> I think this is already out of date, though, now that O.p.toString doesn't use
> %_ClassOf. I'll send a fix (and more tests).

Ah, didn't see the bootstrapper changes. Looks like this actually does the right
thing there too (though direct tests for O.p.toString might still be a good
idea).